diff options
| author | Christian Breunig <christian@breunig.cc> | 2024-04-11 16:51:36 +0200 | 
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-11 16:51:36 +0200 | 
| commit | a17539f4ff5ab7181d10e85f6aefbf51b53309cd (patch) | |
| tree | 4587c6d4bcfd2b8acab03648794b920e2354cd4a | |
| parent | 5d890037b177ce6971ac00f52e4cce2cac898f46 (diff) | |
| parent | c455a1f71674300b8a74863ddfe6e551fe8fd252 (diff) | |
| download | vyos-1x-a17539f4ff5ab7181d10e85f6aefbf51b53309cd.tar.gz vyos-1x-a17539f4ff5ab7181d10e85f6aefbf51b53309cd.zip | |
Merge pull request #3281 from nicolas-fort/T6213
T6214: T6213: change constraint <alpha-numeric-hyphen-underscore-dot.xml.i>
| -rw-r--r-- | interface-definitions/firewall.xml.in | 26 | ||||
| -rw-r--r-- | interface-definitions/include/constraint/alpha-numeric-hyphen-underscore-dot.xml.i | 2 | 
2 files changed, 18 insertions, 10 deletions
| diff --git a/interface-definitions/firewall.xml.in b/interface-definitions/firewall.xml.in index 3219471b1..24e63c5ec 100644 --- a/interface-definitions/firewall.xml.in +++ b/interface-definitions/firewall.xml.in @@ -56,8 +56,9 @@              <properties>                <help>Firewall address-group</help>                <constraint> -                <regex>[a-zA-Z0-9][\w\-\.]*</regex> +                #include <include/constraint/alpha-numeric-hyphen-underscore-dot.xml.i>                </constraint> +              <constraintErrorMessage>Name of firewall group can only contain alphanumeric letters, hyphen, underscores and dot</constraintErrorMessage>              </properties>              <children>                <leafNode name="address"> @@ -96,7 +97,7 @@                <constraint>                  <regex>[a-zA-Z_][a-zA-Z0-9]?[\w\-\.]*</regex>                </constraint> -              <constraintErrorMessage>Name of domain-group can only contain alpha-numeric letters, hyphen, underscores and not start with numeric</constraintErrorMessage> +              <constraintErrorMessage>Name of domain-group can only contain alphanumeric letters, hyphen, underscores and not start with numeric</constraintErrorMessage>              </properties>              <children>                <leafNode name="address"> @@ -124,8 +125,9 @@                  <properties>                    <help>Firewall dynamic address group</help>                    <constraint> -                    <regex>[a-zA-Z0-9][\w\-\.]*</regex> +                    #include <include/constraint/alpha-numeric-hyphen-underscore-dot.xml.i>                    </constraint> +                  <constraintErrorMessage>Name of firewall group can only contain alphanumeric letters, hyphen, underscores and dot</constraintErrorMessage>                  </properties>                  <children>                    #include <include/generic-description.xml.i> @@ -148,8 +150,9 @@              <properties>                <help>Firewall interface-group</help>                <constraint> -                <regex>[a-zA-Z0-9][\w\-\.]*</regex> +                #include <include/constraint/alpha-numeric-hyphen-underscore-dot.xml.i>                </constraint> +              <constraintErrorMessage>Name of firewall group can only contain alphanumeric letters, hyphen, underscores and dot</constraintErrorMessage>              </properties>              <children>                <leafNode name="interface"> @@ -177,8 +180,9 @@              <properties>                <help>Firewall ipv6-address-group</help>                <constraint> -                <regex>[a-zA-Z0-9][\w\-\.]*</regex> +                #include <include/constraint/alpha-numeric-hyphen-underscore-dot.xml.i>                </constraint> +              <constraintErrorMessage>Name of firewall group can only contain alphanumeric letters, hyphen, underscores and dot</constraintErrorMessage>              </properties>              <children>                <leafNode name="address"> @@ -215,8 +219,9 @@              <properties>                <help>Firewall ipv6-network-group</help>                <constraint> -                <regex>[a-zA-Z0-9][\w\-\.]*</regex> +                #include <include/constraint/alpha-numeric-hyphen-underscore-dot.xml.i>                </constraint> +              <constraintErrorMessage>Name of firewall group can only contain alphanumeric letters, hyphen, underscores and dot</constraintErrorMessage>              </properties>              <children>                #include <include/generic-description.xml.i> @@ -248,8 +253,9 @@              <properties>                <help>Firewall mac-group</help>                <constraint> -                <regex>[a-zA-Z0-9][\w\-\.]*</regex> +                #include <include/constraint/alpha-numeric-hyphen-underscore-dot.xml.i>                </constraint> +              <constraintErrorMessage>Name of firewall group can only contain alphanumeric letters, hyphen, underscores and dot</constraintErrorMessage>              </properties>              <children>                #include <include/generic-description.xml.i> @@ -281,8 +287,9 @@              <properties>                <help>Firewall network-group</help>                <constraint> -                <regex>[a-zA-Z0-9][\w\-\.]*</regex> +                #include <include/constraint/alpha-numeric-hyphen-underscore-dot.xml.i>                </constraint> +              <constraintErrorMessage>Name of firewall group can only contain alphanumeric letters, hyphen, underscores and dot</constraintErrorMessage>              </properties>              <children>                #include <include/generic-description.xml.i> @@ -314,8 +321,9 @@              <properties>                <help>Firewall port-group</help>                <constraint> -                <regex>[a-zA-Z0-9][\w\-\.]*</regex> +                #include <include/constraint/alpha-numeric-hyphen-underscore-dot.xml.i>                </constraint> +              <constraintErrorMessage>Name of firewall group can only contain alphanumeric letters, hyphen, underscores and dot</constraintErrorMessage>              </properties>              <children>                #include <include/generic-description.xml.i> diff --git a/interface-definitions/include/constraint/alpha-numeric-hyphen-underscore-dot.xml.i b/interface-definitions/include/constraint/alpha-numeric-hyphen-underscore-dot.xml.i index 7aeb85260..34c94e53c 100644 --- a/interface-definitions/include/constraint/alpha-numeric-hyphen-underscore-dot.xml.i +++ b/interface-definitions/include/constraint/alpha-numeric-hyphen-underscore-dot.xml.i @@ -1,3 +1,3 @@  <!-- include start from constraint/alpha-numeric-hyphen-underscore-dot.xml.i --> -<regex>[-_a-zA-Z0-9.]+</regex> +<regex>[-_a-zA-Z0-9][\w\-\.\+]*</regex>  <!-- include end --> | 
