diff options
| author | Christian Breunig <christian@breunig.cc> | 2023-03-09 19:39:20 +0100 | 
|---|---|---|
| committer | Christian Breunig <christian@breunig.cc> | 2023-03-09 19:40:00 +0100 | 
| commit | fe4da6288649b32779d30d5672e39cae40e72100 (patch) | |
| tree | bd6c16cb19bc5ee1b1e0b5f13c8bca9c6c7e62f1 | |
| parent | 0f3710927eaba4f855119a86046c5e2a5eb76d8b (diff) | |
| download | vyos-1x-fe4da6288649b32779d30d5672e39cae40e72100.tar.gz vyos-1x-fe4da6288649b32779d30d5672e39cae40e72100.zip  | |
xml: T4952: improve interface completion helper CLI experience
56 files changed, 70 insertions, 124 deletions
diff --git a/interface-definitions/dhcp-relay.xml.in b/interface-definitions/dhcp-relay.xml.in index df2821881..79ad2c01c 100644 --- a/interface-definitions/dhcp-relay.xml.in +++ b/interface-definitions/dhcp-relay.xml.in @@ -14,7 +14,7 @@              <properties>                <help>Interface for DHCP Relay Agent to listen for requests</help>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py</script> +                <script>${vyos_completion_dir}/list_interfaces</script>                </completionHelp>                <valueHelp>                  <format>txt</format> @@ -30,7 +30,7 @@              <properties>                <help>Interface for DHCP Relay Agent forward requests out</help>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py</script> +                <script>${vyos_completion_dir}/list_interfaces</script>                </completionHelp>                <valueHelp>                  <format>txt</format> diff --git a/interface-definitions/dhcpv6-relay.xml.in b/interface-definitions/dhcpv6-relay.xml.in index 5abcbe804..947adef75 100644 --- a/interface-definitions/dhcpv6-relay.xml.in +++ b/interface-definitions/dhcpv6-relay.xml.in @@ -13,7 +13,7 @@              <properties>                <help>Interface for DHCPv6 Relay Agent to listen for requests</help>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py</script> +                <script>${vyos_completion_dir}/list_interfaces</script>                </completionHelp>              </properties>              <children> @@ -49,7 +49,7 @@              <properties>                <help>Interface for DHCPv6 Relay Agent forward requests out</help>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py</script> +                <script>${vyos_completion_dir}/list_interfaces</script>                </completionHelp>              </properties>              <children> diff --git a/interface-definitions/dns-domain-name.xml.in b/interface-definitions/dns-domain-name.xml.in index e4d8c0f90..c0ac16a80 100644 --- a/interface-definitions/dns-domain-name.xml.in +++ b/interface-definitions/dns-domain-name.xml.in @@ -7,7 +7,7 @@            <help>System Domain Name Servers (DNS)</help>            <priority>400</priority>            <completionHelp> -            <script>${vyos_completion_dir}/list_interfaces.py</script> +            <script>${vyos_completion_dir}/list_interfaces</script>            </completionHelp>            <valueHelp>              <format>ipv4</format> diff --git a/interface-definitions/dns-dynamic.xml.in b/interface-definitions/dns-dynamic.xml.in index a39e412b2..58dd48f9d 100644 --- a/interface-definitions/dns-dynamic.xml.in +++ b/interface-definitions/dns-dynamic.xml.in @@ -16,7 +16,7 @@                  <properties>                    <help>Interface to send DDNS updates for</help>                    <completionHelp> -                    <script>${vyos_completion_dir}/list_interfaces.py</script> +                    <script>${vyos_completion_dir}/list_interfaces</script>                    </completionHelp>                  </properties>                  <children> diff --git a/interface-definitions/dns-forwarding.xml.in b/interface-definitions/dns-forwarding.xml.in index 409028572..371f198c6 100644 --- a/interface-definitions/dns-forwarding.xml.in +++ b/interface-definitions/dns-forwarding.xml.in @@ -31,7 +31,7 @@                  <properties>                    <help>Interfaces whose DHCP client nameservers to forward requests to</help>                    <completionHelp> -                    <script>${vyos_completion_dir}/list_interfaces.py</script> +                    <script>${vyos_completion_dir}/list_interfaces</script>                    </completionHelp>                    <multi/>                  </properties> diff --git a/interface-definitions/firewall.xml.in b/interface-definitions/firewall.xml.in index c9a132c4a..d27839700 100644 --- a/interface-definitions/firewall.xml.in +++ b/interface-definitions/firewall.xml.in @@ -146,7 +146,7 @@                  <properties>                    <help>Interface-group member</help>                    <completionHelp> -                    <script>${vyos_completion_dir}/list_interfaces.py</script> +                    <script>${vyos_completion_dir}/list_interfaces</script>                    </completionHelp>                    <multi/>                  </properties> @@ -347,7 +347,7 @@          <properties>            <help>Interface name to apply firewall configuration</help>            <completionHelp> -            <script>${vyos_completion_dir}/list_interfaces.py</script> +            <script>${vyos_completion_dir}/list_interfaces</script>            </completionHelp>          </properties>          <children> @@ -912,7 +912,7 @@                  <description>Interface associated with zone</description>                </valueHelp>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py</script> +                <script>${vyos_completion_dir}/list_interfaces</script>                </completionHelp>                <multi/>              </properties> diff --git a/interface-definitions/high-availability.xml.in b/interface-definitions/high-availability.xml.in index 6cb40247a..1fa051df9 100644 --- a/interface-definitions/high-availability.xml.in +++ b/interface-definitions/high-availability.xml.in @@ -213,7 +213,7 @@                      <properties>                        <help>Interface name state check</help>                        <completionHelp> -                        <script>${vyos_completion_dir}/list_interfaces.py --broadcast</script> +                        <script>${vyos_completion_dir}/list_interfaces --broadcast</script>                        </completionHelp>                        <valueHelp>                          <format>txt</format> diff --git a/interface-definitions/igmp-proxy.xml.in b/interface-definitions/igmp-proxy.xml.in index 50cb33a93..0eea85060 100644 --- a/interface-definitions/igmp-proxy.xml.in +++ b/interface-definitions/igmp-proxy.xml.in @@ -20,7 +20,7 @@              <properties>                <help>Interface for IGMP proxy</help>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py</script> +                <script>${vyos_completion_dir}/list_interfaces</script>                </completionHelp>              </properties>              <children> diff --git a/interface-definitions/include/babel/interface.xml.i b/interface-definitions/include/babel/interface.xml.i index 549e4909d..586eca7a5 100644 --- a/interface-definitions/include/babel/interface.xml.i +++ b/interface-definitions/include/babel/interface.xml.i @@ -3,7 +3,7 @@    <properties>      <help>Interface name</help>      <completionHelp> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>      <valueHelp>        <format>txt</format> diff --git a/interface-definitions/include/bgp/neighbor-update-source.xml.i b/interface-definitions/include/bgp/neighbor-update-source.xml.i index 60c127e8f..0acec4126 100644 --- a/interface-definitions/include/bgp/neighbor-update-source.xml.i +++ b/interface-definitions/include/bgp/neighbor-update-source.xml.i @@ -5,7 +5,7 @@      <help>Source IP of routing updates</help>      <completionHelp>        <script>${vyos_completion_dir}/list_local_ips.sh --both</script> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>      <valueHelp>        <format>ipv4</format> diff --git a/interface-definitions/include/bgp/protocol-common-config.xml.i b/interface-definitions/include/bgp/protocol-common-config.xml.i index 0d88c7b25..7a3617044 100644 --- a/interface-definitions/include/bgp/protocol-common-config.xml.i +++ b/interface-definitions/include/bgp/protocol-common-config.xml.i @@ -359,7 +359,7 @@                <properties>                  <help>Interface</help>                  <completionHelp> -                  <script>${vyos_completion_dir}/list_interfaces.py</script> +                  <script>${vyos_completion_dir}/list_interfaces</script>                  </completionHelp>                  <multi/>                </properties> @@ -739,7 +739,7 @@                <properties>                  <help>Interface</help>                  <completionHelp> -                  <script>${vyos_completion_dir}/list_interfaces.py</script> +                  <script>${vyos_completion_dir}/list_interfaces</script>                  </completionHelp>                  <multi/>                </properties> diff --git a/interface-definitions/include/dhcp-interface-multi.xml.i b/interface-definitions/include/dhcp-interface-multi.xml.i index c74751a19..e10341037 100644 --- a/interface-definitions/include/dhcp-interface-multi.xml.i +++ b/interface-definitions/include/dhcp-interface-multi.xml.i @@ -3,7 +3,7 @@    <properties>      <help>DHCP interface supplying next-hop IP address</help>      <completionHelp> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>      <valueHelp>        <format>txt</format> diff --git a/interface-definitions/include/dhcp-interface.xml.i b/interface-definitions/include/dhcp-interface.xml.i index f5107ba2b..24edbbd15 100644 --- a/interface-definitions/include/dhcp-interface.xml.i +++ b/interface-definitions/include/dhcp-interface.xml.i @@ -2,7 +2,7 @@        <properties>          <help>DHCP interface supplying next-hop IP address</help>          <completionHelp> -          <script>${vyos_completion_dir}/list_interfaces.py</script> +          <script>${vyos_completion_dir}/list_interfaces</script>          </completionHelp>          <valueHelp>            <format>txt</format> diff --git a/interface-definitions/include/eigrp/protocol-common-config.xml.i b/interface-definitions/include/eigrp/protocol-common-config.xml.i index 30ddc5d11..88365187a 100644 --- a/interface-definitions/include/eigrp/protocol-common-config.xml.i +++ b/interface-definitions/include/eigrp/protocol-common-config.xml.i @@ -59,7 +59,7 @@    <properties>      <help>Suppress routing updates on an interface</help>      <completionHelp> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>    </properties>  </leafNode> diff --git a/interface-definitions/include/firewall/match-interface.xml.i b/interface-definitions/include/firewall/match-interface.xml.i index 675a87574..3e52422cf 100644 --- a/interface-definitions/include/firewall/match-interface.xml.i +++ b/interface-definitions/include/firewall/match-interface.xml.i @@ -3,7 +3,7 @@    <properties>      <help>Match interface</help>      <completionHelp> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>    </properties>  </leafNode> diff --git a/interface-definitions/include/generic-interface-broadcast.xml.i b/interface-definitions/include/generic-interface-broadcast.xml.i index af35a888b..82bfc139b 100644 --- a/interface-definitions/include/generic-interface-broadcast.xml.i +++ b/interface-definitions/include/generic-interface-broadcast.xml.i @@ -3,7 +3,7 @@    <properties>      <help>Interface Name to use</help>      <completionHelp> -      <script>${vyos_completion_dir}/list_interfaces.py --broadcast</script> +      <script>${vyos_completion_dir}/list_interfaces --broadcast</script>      </completionHelp>      <valueHelp>        <format>txt</format> diff --git a/interface-definitions/include/generic-interface-multi-broadcast.xml.i b/interface-definitions/include/generic-interface-multi-broadcast.xml.i index 1ae38fb43..8160f816d 100644 --- a/interface-definitions/include/generic-interface-multi-broadcast.xml.i +++ b/interface-definitions/include/generic-interface-multi-broadcast.xml.i @@ -3,7 +3,7 @@    <properties>      <help>Interface Name to use</help>      <completionHelp> -      <script>${vyos_completion_dir}/list_interfaces.py --broadcast</script> +      <script>${vyos_completion_dir}/list_interfaces --broadcast</script>      </completionHelp>      <valueHelp>        <format>txt</format> diff --git a/interface-definitions/include/generic-interface-multi.xml.i b/interface-definitions/include/generic-interface-multi.xml.i index 16916ff54..1b8dc102b 100644 --- a/interface-definitions/include/generic-interface-multi.xml.i +++ b/interface-definitions/include/generic-interface-multi.xml.i @@ -3,7 +3,7 @@    <properties>      <help>Interface to use</help>      <completionHelp> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>      <valueHelp>        <format>txt</format> diff --git a/interface-definitions/include/generic-interface.xml.i b/interface-definitions/include/generic-interface.xml.i index 36ddee417..9417f9ef0 100644 --- a/interface-definitions/include/generic-interface.xml.i +++ b/interface-definitions/include/generic-interface.xml.i @@ -3,7 +3,7 @@    <properties>      <help>Interface to use</help>      <completionHelp> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>      <valueHelp>        <format>txt</format> diff --git a/interface-definitions/include/inbound-interface.xml.i b/interface-definitions/include/inbound-interface.xml.i index 3289bbf8f..422f9de75 100644 --- a/interface-definitions/include/inbound-interface.xml.i +++ b/interface-definitions/include/inbound-interface.xml.i @@ -4,7 +4,7 @@      <help>Inbound interface of NAT traffic</help>      <completionHelp>        <list>any</list> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>    </properties>  </leafNode> diff --git a/interface-definitions/include/interface/dhcpv6-options.xml.i b/interface-definitions/include/interface/dhcpv6-options.xml.i index c705af7c2..609af1a2b 100644 --- a/interface-definitions/include/interface/dhcpv6-options.xml.i +++ b/interface-definitions/include/interface/dhcpv6-options.xml.i @@ -51,7 +51,7 @@            <properties>              <help>Delegate IPv6 prefix from provider to this interface</help>              <completionHelp> -              <script>${vyos_completion_dir}/list_interfaces.py --broadcast</script> +              <script>${vyos_completion_dir}/list_interfaces --broadcast</script>              </completionHelp>            </properties>            <children> diff --git a/interface-definitions/include/interface/inbound-interface.xml.i b/interface-definitions/include/interface/inbound-interface.xml.i index 5a8d47280..96ade331d 100644 --- a/interface-definitions/include/interface/inbound-interface.xml.i +++ b/interface-definitions/include/interface/inbound-interface.xml.i @@ -3,7 +3,7 @@    <properties>    <help>Inbound Interface</help>    <completionHelp> -    <script>${vyos_completion_dir}/list_interfaces.py</script> +    <script>${vyos_completion_dir}/list_interfaces</script>    </completionHelp>    </properties>  </leafNode> diff --git a/interface-definitions/include/interface/mirror.xml.i b/interface-definitions/include/interface/mirror.xml.i index 74a172b50..903c62777 100644 --- a/interface-definitions/include/interface/mirror.xml.i +++ b/interface-definitions/include/interface/mirror.xml.i @@ -8,7 +8,7 @@        <properties>          <help>Mirror ingress traffic to destination interface</help>          <completionHelp> -          <script>${vyos_completion_dir}/list_interfaces.py</script> +          <script>${vyos_completion_dir}/list_interfaces</script>          </completionHelp>          <valueHelp>            <format>txt</format> @@ -20,7 +20,7 @@        <properties>          <help>Mirror egress traffic to destination interface</help>          <completionHelp> -          <script>${vyos_completion_dir}/list_interfaces.py</script> +          <script>${vyos_completion_dir}/list_interfaces</script>          </completionHelp>          <valueHelp>            <format>txt</format> diff --git a/interface-definitions/include/interface/redirect.xml.i b/interface-definitions/include/interface/redirect.xml.i index b01e486ce..0421f4074 100644 --- a/interface-definitions/include/interface/redirect.xml.i +++ b/interface-definitions/include/interface/redirect.xml.i @@ -3,7 +3,7 @@    <properties>      <help>Redirect incoming packet to destination</help>      <completionHelp> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>      <valueHelp>        <format>txt</format> diff --git a/interface-definitions/include/isis/protocol-common-config.xml.i b/interface-definitions/include/isis/protocol-common-config.xml.i index c44939528..0e6f19480 100644 --- a/interface-definitions/include/isis/protocol-common-config.xml.i +++ b/interface-definitions/include/isis/protocol-common-config.xml.i @@ -572,7 +572,7 @@    <properties>      <help>Interface params</help>      <completionHelp> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>    </properties>    <children> diff --git a/interface-definitions/include/nat-interface.xml.i b/interface-definitions/include/nat-interface.xml.i index 68969472f..ef1ffc1ba 100644 --- a/interface-definitions/include/nat-interface.xml.i +++ b/interface-definitions/include/nat-interface.xml.i @@ -4,7 +4,7 @@      <help>Outbound interface of NAT traffic</help>      <completionHelp>        <list>any</list> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>    </properties>  </leafNode> diff --git a/interface-definitions/include/ospf/protocol-common-config.xml.i b/interface-definitions/include/ospf/protocol-common-config.xml.i index 16b346131..25b54b181 100644 --- a/interface-definitions/include/ospf/protocol-common-config.xml.i +++ b/interface-definitions/include/ospf/protocol-common-config.xml.i @@ -351,7 +351,7 @@    <properties>      <help>Interface configuration</help>      <completionHelp> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>      <valueHelp>        <format>txt</format> diff --git a/interface-definitions/include/ospfv3/protocol-common-config.xml.i b/interface-definitions/include/ospfv3/protocol-common-config.xml.i index fd00af95e..014bf9e49 100644 --- a/interface-definitions/include/ospfv3/protocol-common-config.xml.i +++ b/interface-definitions/include/ospfv3/protocol-common-config.xml.i @@ -111,7 +111,7 @@    <properties>      <help>Enable routing on an IPv6 interface</help>      <completionHelp> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>      <valueHelp>        <format>txt</format> diff --git a/interface-definitions/include/rip/interface.xml.i b/interface-definitions/include/rip/interface.xml.i index e0792cdc1..0a89f4d92 100644 --- a/interface-definitions/include/rip/interface.xml.i +++ b/interface-definitions/include/rip/interface.xml.i @@ -3,7 +3,7 @@    <properties>      <help>Interface name</help>      <completionHelp> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>      <valueHelp>        <format>txt</format> diff --git a/interface-definitions/include/routing-passive-interface.xml.i b/interface-definitions/include/routing-passive-interface.xml.i index fe229aebe..715468e59 100644 --- a/interface-definitions/include/routing-passive-interface.xml.i +++ b/interface-definitions/include/routing-passive-interface.xml.i @@ -4,7 +4,7 @@      <help>Suppress routing updates on an interface</help>      <completionHelp>        <list>default</list> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>      <valueHelp>        <format>txt</format> diff --git a/interface-definitions/include/source-interface-ethernet.xml.i b/interface-definitions/include/source-interface-ethernet.xml.i index ee04f2cd5..e06e47d6c 100644 --- a/interface-definitions/include/source-interface-ethernet.xml.i +++ b/interface-definitions/include/source-interface-ethernet.xml.i @@ -7,7 +7,7 @@        <description>Physical interface used for traffic forwarding</description>      </valueHelp>      <completionHelp> -      <script>${vyos_completion_dir}/list_interfaces.py -t ethernet</script> +      <script>${vyos_completion_dir}/list_interfaces --type ethernet</script>      </completionHelp>    </properties>  </leafNode> diff --git a/interface-definitions/include/source-interface.xml.i b/interface-definitions/include/source-interface.xml.i index 4c1fddb57..c25a6a6d0 100644 --- a/interface-definitions/include/source-interface.xml.i +++ b/interface-definitions/include/source-interface.xml.i @@ -7,7 +7,7 @@        <description>Interface name</description>      </valueHelp>      <completionHelp> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>      <constraint>        #include <include/constraint/interface-name.xml.in> diff --git a/interface-definitions/include/static/static-route-interface.xml.i b/interface-definitions/include/static/static-route-interface.xml.i index cc7a92612..db2f0baa6 100644 --- a/interface-definitions/include/static/static-route-interface.xml.i +++ b/interface-definitions/include/static/static-route-interface.xml.i @@ -3,7 +3,7 @@    <properties>      <help>Gateway interface name</help>      <completionHelp> -      <script>${vyos_completion_dir}/list_interfaces.py</script> +      <script>${vyos_completion_dir}/list_interfaces</script>      </completionHelp>      <valueHelp>        <format>txt</format> diff --git a/interface-definitions/include/static/static-route.xml.i b/interface-definitions/include/static/static-route.xml.i index aeb2044c9..34e36f5a7 100644 --- a/interface-definitions/include/static/static-route.xml.i +++ b/interface-definitions/include/static/static-route.xml.i @@ -19,7 +19,7 @@        <properties>          <help>Next-hop IPv4 router interface</help>          <completionHelp> -          <script>${vyos_completion_dir}/list_interfaces.py</script> +          <script>${vyos_completion_dir}/list_interfaces</script>          </completionHelp>          <valueHelp>            <format>txt</format> diff --git a/interface-definitions/include/static/static-route6.xml.i b/interface-definitions/include/static/static-route6.xml.i index d5e7a25bc..aac02062f 100644 --- a/interface-definitions/include/static/static-route6.xml.i +++ b/interface-definitions/include/static/static-route6.xml.i @@ -18,7 +18,7 @@        <properties>          <help>IPv6 gateway interface name</help>          <completionHelp> -          <script>${vyos_completion_dir}/list_interfaces.py</script> +          <script>${vyos_completion_dir}/list_interfaces</script>          </completionHelp>          <valueHelp>            <format>txt</format> diff --git a/interface-definitions/interfaces-bonding.xml.in b/interface-definitions/interfaces-bonding.xml.in index 6e8c5283a..f5f1eb1b6 100644 --- a/interface-definitions/interfaces-bonding.xml.in +++ b/interface-definitions/interfaces-bonding.xml.in @@ -192,7 +192,7 @@                  <properties>                    <help>Member interface name</help>                    <completionHelp> -                    <script>${vyos_completion_dir}/list_interfaces.py --bondable</script> +                    <script>${vyos_completion_dir}/list_interfaces --bondable</script>                    </completionHelp>                    <valueHelp>                      <format>txt</format> @@ -211,7 +211,7 @@              <properties>                <help>Primary device interface</help>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py --bondable</script> +                <script>${vyos_completion_dir}/list_interfaces --bondable</script>                </completionHelp>                <valueHelp>                  <format>txt</format> diff --git a/interface-definitions/interfaces-bridge.xml.in b/interface-definitions/interfaces-bridge.xml.in index 1636411ec..fcfb8686c 100644 --- a/interface-definitions/interfaces-bridge.xml.in +++ b/interface-definitions/interfaces-bridge.xml.in @@ -121,7 +121,7 @@                  <properties>                    <help>Member interface name</help>                    <completionHelp> -                    <script>${vyos_completion_dir}/list_interfaces.py --bridgeable</script> +                    <script>${vyos_completion_dir}/list_interfaces --bridgeable</script>                    </completionHelp>                  </properties>                  <children> diff --git a/interface-definitions/load-balancing-wan.xml.in b/interface-definitions/load-balancing-wan.xml.in index c2b6316ae..2b812eb4d 100644 --- a/interface-definitions/load-balancing-wan.xml.in +++ b/interface-definitions/load-balancing-wan.xml.in @@ -44,7 +44,7 @@              <properties>                <help>Interface name</help>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py</script> +                <script>${vyos_completion_dir}/list_interfaces</script>                </completionHelp>              </properties>              <children> @@ -226,7 +226,7 @@                    <help>Inbound interface name (e.g., "eth0") [REQUIRED]</help>                    <completionHelp>                      <list>any</list> -                    <script>${vyos_completion_dir}/list_interfaces.py</script> +                    <script>${vyos_completion_dir}/list_interfaces</script>                    </completionHelp>                  </properties>                </leafNode> @@ -234,7 +234,7 @@                  <properties>                    <help>Interface name [REQUIRED]</help>                    <completionHelp> -                    <script>${vyos_completion_dir}/list_interfaces.py</script> +                    <script>${vyos_completion_dir}/list_interfaces</script>                    </completionHelp>                  </properties>                  <children> diff --git a/interface-definitions/nat66.xml.in b/interface-definitions/nat66.xml.in index dab4543e0..6ea611789 100644 --- a/interface-definitions/nat66.xml.in +++ b/interface-definitions/nat66.xml.in @@ -46,7 +46,7 @@                  <properties>                    <help>Outbound interface of NAT66 traffic</help>                    <completionHelp> -                    <script>${vyos_completion_dir}/list_interfaces.py</script> +                    <script>${vyos_completion_dir}/list_interfaces</script>                    </completionHelp>                  </properties>                </leafNode> @@ -179,7 +179,7 @@                    <help>Inbound interface of NAT66 traffic</help>                    <completionHelp>                      <list>any</list> -                    <script>${vyos_completion_dir}/list_interfaces.py</script> +                    <script>${vyos_completion_dir}/list_interfaces</script>                    </completionHelp>                  </properties>                </leafNode> diff --git a/interface-definitions/protocols-babel.xml.in b/interface-definitions/protocols-babel.xml.in index 0ef833077..b3377aac1 100644 --- a/interface-definitions/protocols-babel.xml.in +++ b/interface-definitions/protocols-babel.xml.in @@ -203,7 +203,7 @@                          <description>Apply filtering to an interface</description>                        </valueHelp>                        <completionHelp> -                        <script>${vyos_completion_dir}/list_interfaces.py</script> +                        <script>${vyos_completion_dir}/list_interfaces</script>                        </completionHelp>                        <constraint>                          #include <include/constraint/interface-name.xml.in> @@ -231,7 +231,7 @@                          <description>Apply filtering to an interface</description>                        </valueHelp>                        <completionHelp> -                        <script>${vyos_completion_dir}/list_interfaces.py</script> +                        <script>${vyos_completion_dir}/list_interfaces</script>                        </completionHelp>                        <constraint>                          #include <include/constraint/interface-name.xml.in> diff --git a/interface-definitions/protocols-igmp.xml.in b/interface-definitions/protocols-igmp.xml.in index e10340512..a055db71e 100644 --- a/interface-definitions/protocols-igmp.xml.in +++ b/interface-definitions/protocols-igmp.xml.in @@ -12,7 +12,7 @@              <properties>                <help>IGMP interface</help>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py</script> +                <script>${vyos_completion_dir}/list_interfaces</script>                </completionHelp>              </properties>              <children> diff --git a/interface-definitions/protocols-multicast.xml.in b/interface-definitions/protocols-multicast.xml.in index b1791c471..c8e28ed35 100644 --- a/interface-definitions/protocols-multicast.xml.in +++ b/interface-definitions/protocols-multicast.xml.in @@ -65,7 +65,7 @@                      <properties>                        <help>Next-hop interface</help>                        <completionHelp> -                        <script>${vyos_completion_dir}/list_interfaces.py</script> +                        <script>${vyos_completion_dir}/list_interfaces</script>                        </completionHelp>                      </properties>                      <children> diff --git a/interface-definitions/protocols-pim.xml.in b/interface-definitions/protocols-pim.xml.in index bb5cc797b..e9475930c 100644 --- a/interface-definitions/protocols-pim.xml.in +++ b/interface-definitions/protocols-pim.xml.in @@ -13,7 +13,7 @@              <properties>                <help>PIM interface</help>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py</script> +                <script>${vyos_completion_dir}/list_interfaces</script>                </completionHelp>              </properties>              <children> diff --git a/interface-definitions/protocols-rip.xml.in b/interface-definitions/protocols-rip.xml.in index b5d48090a..68d2b64ca 100644 --- a/interface-definitions/protocols-rip.xml.in +++ b/interface-definitions/protocols-rip.xml.in @@ -36,7 +36,7 @@                      <description>Apply filtering to an interface</description>                    </valueHelp>                    <completionHelp> -                    <script>${vyos_completion_dir}/list_interfaces.py</script> +                    <script>${vyos_completion_dir}/list_interfaces</script>                    </completionHelp>                    <constraint>                      #include <include/constraint/interface-name.xml.in> diff --git a/interface-definitions/protocols-ripng.xml.in b/interface-definitions/protocols-ripng.xml.in index cf000b824..be643896f 100644 --- a/interface-definitions/protocols-ripng.xml.in +++ b/interface-definitions/protocols-ripng.xml.in @@ -37,7 +37,7 @@                      <description>Apply filtering to an interface</description>                    </valueHelp>                    <completionHelp> -                    <script>${vyos_completion_dir}/list_interfaces.py</script> +                    <script>${vyos_completion_dir}/list_interfaces</script>                    </completionHelp>                    <constraint>                      #include <include/constraint/interface-name.xml.in> @@ -73,7 +73,7 @@                  <description>Suppress routing updates on interface</description>                </valueHelp>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py</script> +                <script>${vyos_completion_dir}/list_interfaces</script>                </completionHelp>                <multi/>              </properties> diff --git a/interface-definitions/protocols-static-arp.xml.in b/interface-definitions/protocols-static-arp.xml.in index 52caf435a..63f450bd8 100644 --- a/interface-definitions/protocols-static-arp.xml.in +++ b/interface-definitions/protocols-static-arp.xml.in @@ -13,7 +13,7 @@                  <properties>                    <help>Interface configuration</help>                    <completionHelp> -                    <script>${vyos_completion_dir}/list_interfaces.py</script> +                    <script>${vyos_completion_dir}/list_interfaces</script>                    </completionHelp>                    <valueHelp>                      <format>txt</format> diff --git a/interface-definitions/qos.xml.in b/interface-definitions/qos.xml.in index 757c1f856..9b1430ea0 100644 --- a/interface-definitions/qos.xml.in +++ b/interface-definitions/qos.xml.in @@ -10,7 +10,7 @@          <properties>            <help>Interface to apply QoS policy</help>            <completionHelp> -            <script>${vyos_completion_dir}/list_interfaces.py</script> +            <script>${vyos_completion_dir}/list_interfaces</script>            </completionHelp>            <valueHelp>              <format>txt</format> diff --git a/interface-definitions/service-conntrack-sync.xml.in b/interface-definitions/service-conntrack-sync.xml.in index 6fa6fc5f9..50a4bf62f 100644 --- a/interface-definitions/service-conntrack-sync.xml.in +++ b/interface-definitions/service-conntrack-sync.xml.in @@ -127,7 +127,7 @@              <properties>                <help>Interface to use for syncing conntrack entries</help>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py --bridgeable</script> +                <script>${vyos_completion_dir}/list_interfaces --bridgeable</script>                </completionHelp>              </properties>              <children> diff --git a/interface-definitions/service-ids-ddos-protection.xml.in b/interface-definitions/service-ids-ddos-protection.xml.in index a661b845d..bb06189bc 100644 --- a/interface-definitions/service-ids-ddos-protection.xml.in +++ b/interface-definitions/service-ids-ddos-protection.xml.in @@ -65,7 +65,7 @@                  <properties>                    <help>Listen interface for mirroring traffic</help>                    <completionHelp> -                    <script>${vyos_completion_dir}/list_interfaces.py</script> +                    <script>${vyos_completion_dir}/list_interfaces</script>                    </completionHelp>                    <multi/>                  </properties> diff --git a/interface-definitions/service-ipoe-server.xml.in b/interface-definitions/service-ipoe-server.xml.in index ebe99d3aa..b6e6503d3 100644 --- a/interface-definitions/service-ipoe-server.xml.in +++ b/interface-definitions/service-ipoe-server.xml.in @@ -12,7 +12,7 @@              <properties>                <help>Interface to listen dhcp or unclassified packets</help>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py</script> +                <script>${vyos_completion_dir}/list_interfaces</script>                </completionHelp>              </properties>              <children> @@ -122,7 +122,7 @@                  <properties>                    <help>Network interface for client MAC addresses</help>                    <completionHelp> -                    <script>${vyos_completion_dir}/list_interfaces.py</script> +                    <script>${vyos_completion_dir}/list_interfaces</script>                    </completionHelp>                  </properties>                  <children> diff --git a/interface-definitions/service-pppoe-server.xml.in b/interface-definitions/service-pppoe-server.xml.in index 3fde07019..022ac2885 100644 --- a/interface-definitions/service-pppoe-server.xml.in +++ b/interface-definitions/service-pppoe-server.xml.in @@ -65,7 +65,7 @@              <properties>                <help>interface(s) to listen on</help>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py</script> +                <script>${vyos_completion_dir}/list_interfaces</script>                </completionHelp>              </properties>              <children> diff --git a/interface-definitions/service-router-advert.xml.in b/interface-definitions/service-router-advert.xml.in index 8b7364a8c..16c29022d 100644 --- a/interface-definitions/service-router-advert.xml.in +++ b/interface-definitions/service-router-advert.xml.in @@ -12,7 +12,7 @@              <properties>                <help>Interface to send RA on</help>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py</script> +                <script>${vyos_completion_dir}/list_interfaces</script>                </completionHelp>              </properties>              <children> diff --git a/interface-definitions/service-upnp.xml.in b/interface-definitions/service-upnp.xml.in index 79d8ae42e..9e222d29a 100644 --- a/interface-definitions/service-upnp.xml.in +++ b/interface-definitions/service-upnp.xml.in @@ -21,7 +21,7 @@              <properties>                <help>WAN network interface</help>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py</script> +                <script>${vyos_completion_dir}/list_interfaces</script>                </completionHelp>                <constraint>                  #include <include/constraint/interface-name.xml.in> @@ -95,7 +95,7 @@                <help>Local IP addresses for service to listen on</help>                <completionHelp>                  <script>${vyos_completion_dir}/list_local_ips.sh --both</script> -                <script>${vyos_completion_dir}/list_interfaces.py</script> +                <script>${vyos_completion_dir}/list_interfaces</script>                </completionHelp>                <valueHelp>                  <format><interface></format> diff --git a/interface-definitions/system-conntrack.xml.in b/interface-definitions/system-conntrack.xml.in index 5810a97c6..8dad048b8 100644 --- a/interface-definitions/system-conntrack.xml.in +++ b/interface-definitions/system-conntrack.xml.in @@ -68,7 +68,7 @@                        <help>Interface to ignore connections tracking on</help>                        <completionHelp>                          <list>any</list> -                        <script>${vyos_completion_dir}/list_interfaces.py</script> +                        <script>${vyos_completion_dir}/list_interfaces</script>                        </completionHelp>                      </properties>                    </leafNode> @@ -310,7 +310,7 @@                            <help>Interface to ignore connections tracking on</help>                            <completionHelp>                              <list>any</list> -                            <script>${vyos_completion_dir}/list_interfaces.py</script> +                            <script>${vyos_completion_dir}/list_interfaces</script>                            </completionHelp>                          </properties>                        </leafNode> diff --git a/op-mode-definitions/show-babel.xml.in b/op-mode-definitions/show-babel.xml.in index 3aac3764e..0a1f1b262 100644 --- a/op-mode-definitions/show-babel.xml.in +++ b/op-mode-definitions/show-babel.xml.in @@ -23,7 +23,7 @@              <properties>                <help>Show Babel neighbor information for specified interface</help>                <completionHelp> -                <script>${vyos_completion_dir}/list_interfaces.py</script> +                <script>${vyos_completion_dir}/list_interfaces</script>                </completionHelp>              </properties>              <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command> diff --git a/src/completion/list_interfaces.py b/src/completion/list_interfaces.py deleted file mode 100755 index b19b90156..000000000 --- a/src/completion/list_interfaces.py +++ /dev/null @@ -1,54 +0,0 @@ -#!/usr/bin/env python3 -# -# Copyright (C) 2019-2020 VyOS maintainers and contributors -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License version 2 or later as -# published by the Free Software Foundation. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program.  If not, see <http://www.gnu.org/licenses/>. - -import sys -import argparse -from vyos.ifconfig import Section - -def matching(feature): -    for section in Section.feature(feature): -        for intf in Section.interfaces(section): -            yield intf - -parser = argparse.ArgumentParser() -group = parser.add_mutually_exclusive_group() -group.add_argument("-t", "--type", type=str, help="List interfaces of specific type") -group.add_argument("-b", "--broadcast", action="store_true", help="List all broadcast interfaces") -group.add_argument("-br", "--bridgeable", action="store_true", help="List all bridgeable interfaces") -group.add_argument("-bo", "--bondable", action="store_true", help="List all bondable interfaces") - -args = parser.parse_args() - -if args.type: -    try: -        interfaces = Section.interfaces(args.type) -        print(" ".join(interfaces)) -    except ValueError as e: -        print(e, file=sys.stderr) -        print("") - -elif args.broadcast: -    print(" ".join(matching("broadcast"))) - -elif args.bridgeable: -    print(" ".join(matching("bridgeable"))) - -elif args.bondable: -    # we need to filter out VLAN interfaces identified by a dot (.) in their name -    print(" ".join([intf for intf in matching("bondable") if '.' not in intf])) - -else: -    print(" ".join(Section.interfaces()))  | 
