summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn Estabrook <jestabro@vyos.io>2025-11-03 11:51:13 -0600
committerJohn Estabrook <jestabro@vyos.io>2025-11-20 07:55:25 -0600
commitf26f737f0c58f7f0b5f5299d9f89f45a0143aef6 (patch)
treea8136c865c078f7fb76299a2fdbee67e85304ada
parentb02565cb1ad928926d411fbaa48290c9f347154c (diff)
downloadvyos-1x-f26f737f0c58f7f0b5f5299d9f89f45a0143aef6.tar.gz
vyos-1x-f26f737f0c58f7f0b5f5299d9f89f45a0143aef6.zip
T7988: adjust function name to distinguish compare from show config
-rw-r--r--libvyosconfig/lib/bindings.ml6
-rw-r--r--python/vyos/config_mgmt.py6
-rw-r--r--python/vyos/configtree.py10
3 files changed, 11 insertions, 11 deletions
diff --git a/libvyosconfig/lib/bindings.ml b/libvyosconfig/lib/bindings.ml
index 78ce3deab..3510a9016 100644
--- a/libvyosconfig/lib/bindings.ml
+++ b/libvyosconfig/lib/bindings.ml
@@ -378,7 +378,7 @@ let diff_tree path c_ptr_l c_ptr_r =
| CD.Incommensurable -> error_message := "Incommensurable"; Ctypes.null
| CD.Empty_comparison -> error_message := "Empty comparison"; Ctypes.null
-let show_diff cmds path c_ptr_l c_ptr_r =
+let diff_compare cmds path c_ptr_l c_ptr_r =
(* alert exn CD.show_diff:
[Config_diff.Incommensurable] caught
[Config_diff.Empty_comparison] caught
@@ -387,7 +387,7 @@ let show_diff cmds path c_ptr_l c_ptr_r =
let ct_l = Root.get c_ptr_l in
let ct_r = Root.get c_ptr_r in
try
- (CD.show_diff[@alert "-exn"]) ~cmds:cmds path ct_l ct_r
+ (CD.diff_compare[@alert "-exn"]) ~cmds:cmds path ct_l ct_r
with
| CD.Incommensurable -> error_message := "Incommensurable"; "#1@"
| CD.Empty_comparison -> error_message := "Empty comparison"; "#1@"
@@ -499,7 +499,7 @@ struct
let () = I.internal "return_value" ((ptr void) @-> string @-> returning string) return_value
let () = I.internal "return_values" ((ptr void) @-> string @-> returning string) return_values
let () = I.internal "diff_tree" (string @-> (ptr void) @-> (ptr void) @-> returning (ptr void)) diff_tree
- let () = I.internal "show_diff" (bool @-> string @-> (ptr void) @-> (ptr void) @-> returning string) show_diff
+ let () = I.internal "diff_compare" (bool @-> string @-> (ptr void) @-> (ptr void) @-> returning string) diff_compare
let () = I.internal "tree_union" ((ptr void) @-> (ptr void) @-> returning (ptr void)) tree_union
let () = I.internal "tree_merge" (bool @-> (ptr void) @-> (ptr void) @-> returning (ptr void)) tree_merge
let () = I.internal "reference_tree_to_json" (string @-> string @-> string @-> returning int) reference_tree_to_json
diff --git a/python/vyos/config_mgmt.py b/python/vyos/config_mgmt.py
index 0dbfcc504..6bc9ff333 100644
--- a/python/vyos/config_mgmt.py
+++ b/python/vyos/config_mgmt.py
@@ -37,7 +37,7 @@ from vyos.configtree import ConfigTree
from vyos.configtree import ConfigTreeError
from vyos.configsession import ConfigSession
from vyos.configsession import ConfigSessionError
-from vyos.configtree import show_diff
+from vyos.configtree import diff_compare
from vyos.load_config import load
from vyos.load_config import LoadConfigError
from vyos.defaults import directories
@@ -413,9 +413,9 @@ Proceed ?"""
path = [] if commands else self.edit_path
try:
if commands:
- out = show_diff(ct1, ct2, path=path, commands=True)
+ out = diff_compare(ct1, ct2, path=path, commands=True)
else:
- out = show_diff(ct1, ct2, path=path)
+ out = diff_compare(ct1, ct2, path=path)
except ConfigTreeError as e:
return e, 1
diff --git a/python/vyos/configtree.py b/python/vyos/configtree.py
index e6ea4b40d..e57cd5205 100644
--- a/python/vyos/configtree.py
+++ b/python/vyos/configtree.py
@@ -473,7 +473,7 @@ class ConfigTree(object):
return subt
-def show_diff(left, right, path=[], commands=False, libpath=LIBPATH):
+def diff_compare(left, right, path=[], commands=False, libpath=LIBPATH):
if left is None:
left = ConfigTree(config_string='\n')
if right is None:
@@ -488,14 +488,14 @@ def show_diff(left, right, path=[], commands=False, libpath=LIBPATH):
path_str = ' '.join(map(str, path)).encode()
__lib = cdll.LoadLibrary(libpath)
- __show_diff = __lib.show_diff
- __show_diff.argtypes = [c_bool, c_char_p, c_void_p, c_void_p]
- __show_diff.restype = c_char_p
+ __diff_compare = __lib.diff_compare
+ __diff_compare.argtypes = [c_bool, c_char_p, c_void_p, c_void_p]
+ __diff_compare.restype = c_char_p
__get_error = __lib.get_error
__get_error.argtypes = []
__get_error.restype = c_char_p
- res = __show_diff(commands, path_str, left._get_config(), right._get_config())
+ res = __diff_compare(commands, path_str, left._get_config(), right._get_config())
res = res.decode()
if res == '#1@':
msg = __get_error().decode()