summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Breunig <christian@breunig.cc>2024-04-24 20:46:42 +0200
committerGitHub <noreply@github.com>2024-04-24 20:46:42 +0200
commitafb910c1efbe5f7c98c25688f0eb2546db218dd3 (patch)
tree41112b8d542499d65a28bbe6694172236bbe9cd9
parenta63e934073744772dc9fd919b7bb376ed9ceeab3 (diff)
parenta3713cd64f2f43f321a5138db94bb1a87edbffdd (diff)
downloadvyos-1x-afb910c1efbe5f7c98c25688f0eb2546db218dd3.tar.gz
vyos-1x-afb910c1efbe5f7c98c25688f0eb2546db218dd3.zip
Merge pull request #3359 from sever-sever/T5833
T5833: Not all AFIs compatible with VRF add verify check
-rwxr-xr-xsrc/conf_mode/protocols_bgp.py16
1 files changed, 16 insertions, 0 deletions
diff --git a/src/conf_mode/protocols_bgp.py b/src/conf_mode/protocols_bgp.py
index 2b16de775..4df97d133 100755
--- a/src/conf_mode/protocols_bgp.py
+++ b/src/conf_mode/protocols_bgp.py
@@ -473,6 +473,22 @@ def verify(bgp):
if peer_group_as is None or (peer_group_as != 'internal' and peer_group_as != bgp['system_as']):
raise ConfigError('route-reflector-client only supported for iBGP peers')
+ # T5833 not all AFIs are supported for VRF
+ if 'vrf' in bgp and 'address_family' in peer_config:
+ unsupported_vrf_afi = {
+ 'ipv4_flowspec',
+ 'ipv6_flowspec',
+ 'ipv4_labeled_unicast',
+ 'ipv6_labeled_unicast',
+ 'ipv4_vpn',
+ 'ipv6_vpn',
+ }
+ for afi in peer_config['address_family']:
+ if afi in unsupported_vrf_afi:
+ raise ConfigError(
+ f"VRF is not allowed for address-family '{afi.replace('_', '-')}'"
+ )
+
# Throw an error if a peer group is not configured for allow range
for prefix in dict_search('listen.range', bgp) or []:
# we can not use dict_search() here as prefix contains dots ...