Merge pull request #251 from thomas-mangin/T2057-required

ifconfig: T2057: skip required check if we do not create the interface

1 files changed, 6 insertions, 4 deletions

diff --git a/python/vyos/ifconfig/interface.py b/python/vyos/ifconfig/interface.py
index bb6c33f5f..21ffa88f6 100644
--- a/python/vyos/ifconfig/interface.py
+++ b/python/vyos/ifconfig/interface.py
@@ -170,13 +170,15 @@ class Interface(Control):
             if k in kargs:
                 self.config[k] = kargs[k]
 
-        for k in self.required:
-            if k not in kargs:
-                raise ConfigError('missing required option {} for {}'.format(k,self.__class__))
-
         if not os.path.exists('/sys/class/net/{}'.format(self.config['ifname'])):
             if not self.config['type']:
                 raise Exception('interface "{}" not found'.format(self.config['ifname']))
+
+            for k in self.required:
+                if k not in kargs:
+                    name = self.default['type']
+                    raise ConfigError(f'missing required option {k} for {name} {ifname} creation')
+
             self._create()
 
         # per interface DHCP config files