summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Breunig <christian@breunig.cc>2023-12-10 12:57:56 +0100
committerGitHub <noreply@github.com>2023-12-10 12:57:56 +0100
commit7d536adeabb076793cd75e43f0bf168cfdf4c5f3 (patch)
treefd53f8b6b33ac86861540e1ea93cdcd9f3956ac3
parent8258fedac0c38101051e660a37cb62fbdf6b4bce (diff)
parent0a1c9bc38440c86cbbc016fb6d8f7d6f36993652 (diff)
downloadvyos-1x-7d536adeabb076793cd75e43f0bf168cfdf4c5f3.tar.gz
vyos-1x-7d536adeabb076793cd75e43f0bf168cfdf4c5f3.zip
Merge pull request #2602 from sever-sever/T5791
T5791: DNS dynamic exclude check for dynamic interfaces PPPoE
-rwxr-xr-xsrc/conf_mode/dns_dynamic.py8
1 files changed, 7 insertions, 1 deletions
diff --git a/src/conf_mode/dns_dynamic.py b/src/conf_mode/dns_dynamic.py
index 3ddc8e7fd..c4dcb76ed 100755
--- a/src/conf_mode/dns_dynamic.py
+++ b/src/conf_mode/dns_dynamic.py
@@ -18,6 +18,7 @@ import os
from sys import exit
+from vyos.base import Warning
from vyos.config import Config
from vyos.configverify import verify_interface_exists
from vyos.template import render
@@ -88,7 +89,12 @@ def verify(dyndns):
# If dyndns address is an interface, ensure that it exists
# and that web-options are not set
if config['address'] != 'web':
- verify_interface_exists(config['address'])
+ # exclude check interface for dynamic interfaces
+ interface_filter = ('pppoe', 'sstpc')
+ if config['address'].startswith(interface_filter):
+ Warning(f'interface {config["address"]} does not exist!')
+ else:
+ verify_interface_exists(config['address'])
if 'web_options' in config:
raise ConfigError(f'"web-options" is applicable only when using HTTP(S) web request to obtain the IP address')