summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIndrajit Raychaudhuri <irc@indrajit.com>2023-12-11 00:25:20 -0400
committerIndrajit Raychaudhuri <irc@indrajit.com>2023-12-11 19:00:46 -0400
commit10dfd829ab30c768fdbcc4713da62247835493d8 (patch)
tree770dd2de4787a7bed098b625127276db10c5e63d
parent9c9d8a3be66c3063f1a1b06c1233376081eb58af (diff)
downloadvyos-1x-10dfd829ab30c768fdbcc4713da62247835493d8.tar.gz
vyos-1x-10dfd829ab30c768fdbcc4713da62247835493d8.zip
ddclient: T5791: Cleanup smoketests and remove unnecessary imports
-rwxr-xr-xsmoketest/scripts/cli/test_service_dns_dynamic.py8
1 files changed, 2 insertions, 6 deletions
diff --git a/smoketest/scripts/cli/test_service_dns_dynamic.py b/smoketest/scripts/cli/test_service_dns_dynamic.py
index 3c7303f32..55bdde94a 100755
--- a/smoketest/scripts/cli/test_service_dns_dynamic.py
+++ b/smoketest/scripts/cli/test_service_dns_dynamic.py
@@ -17,8 +17,6 @@
import os
import unittest
import tempfile
-import random
-import string
from base_vyostest_shim import VyOSUnitTestSHIM
@@ -67,14 +65,12 @@ class TestServiceDDNS(VyOSUnitTestSHIM.TestCase):
self.cli_set(name_path + [svc, 'address', interface])
self.cli_set(name_path + [svc, 'host-name', hostname])
self.cli_set(name_path + [svc, 'password', password])
- self.cli_set(name_path + [svc, 'zone', zone])
- self.cli_set(name_path + [svc, 'ttl', ttl])
for opt, value in details.items():
self.cli_set(name_path + [svc, opt, value])
- # 'zone' option is supported and required by 'cloudfare', but not 'freedns' and 'zoneedit'
+ # 'zone' option is supported by 'cloudfare' and 'zoneedit1', but not 'freedns'
self.cli_set(name_path + [svc, 'zone', zone])
- if details['protocol'] == 'cloudflare':
+ if details['protocol'] in ['cloudflare', 'zoneedit1']:
pass
else:
# exception is raised for unsupported ones