summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Poessinger <christian@poessinger.com>2021-04-09 18:01:28 +0200
committerChristian Poessinger <christian@poessinger.com>2021-04-09 18:03:04 +0200
commit07851cb05e60042b372d828581bba9902d396cc8 (patch)
tree4cb3a8e3d2d4f4ac4d6f3a98a75f0aff9b82ece0
parent9056f329844cfdd07c2c6f4324a72602aced9f75 (diff)
downloadvyos-1x-07851cb05e60042b372d828581bba9902d396cc8.tar.gz
vyos-1x-07851cb05e60042b372d828581bba9902d396cc8.zip
bgp: T1711: remove extra script completion helper on peer-groups
After commit 73557d68 ("bgp: T1711: remove ASN tagNode and move to 'local-as'") when the BGP tag node was removed there is no need anymore for a script based completion helper, we can rather rely on the build in "path" variant.
-rw-r--r--interface-definitions/include/bgp/bgp-peer-group.xml.i2
-rwxr-xr-xsrc/completion/list_bgp_peer_groups.sh22
2 files changed, 1 insertions, 23 deletions
diff --git a/interface-definitions/include/bgp/bgp-peer-group.xml.i b/interface-definitions/include/bgp/bgp-peer-group.xml.i
index 8fc50794d..77dab4a8b 100644
--- a/interface-definitions/include/bgp/bgp-peer-group.xml.i
+++ b/interface-definitions/include/bgp/bgp-peer-group.xml.i
@@ -3,7 +3,7 @@
<properties>
<help>Peer group for this peer</help>
<completionHelp>
- <script>${vyos_completion_dir}/list_bgp_peer_groups.sh</script>
+ <path>protocols bgp peer-group</path>
</completionHelp>
<valueHelp>
<format>txt</format>
diff --git a/src/completion/list_bgp_peer_groups.sh b/src/completion/list_bgp_peer_groups.sh
deleted file mode 100755
index 1684271f8..000000000
--- a/src/completion/list_bgp_peer_groups.sh
+++ /dev/null
@@ -1,22 +0,0 @@
-#!/bin/sh
-# Copyright (C) 2021 VyOS maintainers and contributors
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License version 2 or later as
-# published by the Free Software Foundation.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program. If not, see <http://www.gnu.org/licenses/>.
-
-# Return BGP peer-groups from CLI
-
-declare -a vals
-eval "vals=($(cli-shell-api listNodes protocols bgp peer-group))"
-
-echo -n ${vals[@]}
-exit 0