summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Poessinger <christian@poessinger.com>2020-03-22 16:37:15 +0100
committerChristian Poessinger <christian@poessinger.com>2020-03-22 16:37:17 +0100
commit7a509a4d725eb9f9786d9abc59a90fe8e31e4c1f (patch)
tree90a1d4f090aba190ff95841b97df775b53712e8a
parentf90abbe3062a1d687c797ff2f2ffde048430d350 (diff)
downloadvyos-1x-7a509a4d725eb9f9786d9abc59a90fe8e31e4c1f.tar.gz
vyos-1x-7a509a4d725eb9f9786d9abc59a90fe8e31e4c1f.zip
ifconfig: T2104: remove superfluous __init__ in derived classes
__init__ should be added to a derived class only if it does work in the ctor.
-rw-r--r--python/vyos/ifconfig/bond.py3
-rw-r--r--python/vyos/ifconfig/bridge.py3
-rw-r--r--python/vyos/ifconfig/dummy.py3
-rw-r--r--python/vyos/ifconfig/ethernet.py3
-rw-r--r--python/vyos/ifconfig/geneve.py3
-rw-r--r--python/vyos/ifconfig/l2tpv3.py3
-rw-r--r--python/vyos/ifconfig/loopback.py3
-rw-r--r--python/vyos/ifconfig/macvlan.py3
-rw-r--r--python/vyos/ifconfig/vlan.py3
-rw-r--r--python/vyos/ifconfig/vxlan.py3
-rw-r--r--python/vyos/ifconfig/wireguard.py3
11 files changed, 0 insertions, 33 deletions
diff --git a/python/vyos/ifconfig/bond.py b/python/vyos/ifconfig/bond.py
index 211790459..c9dac891f 100644
--- a/python/vyos/ifconfig/bond.py
+++ b/python/vyos/ifconfig/bond.py
@@ -73,9 +73,6 @@ class BondIf(VLANIf):
'type': 'bond',
}
- def __init__(self, ifname, **kargs):
- super().__init__(ifname, **kargs)
-
def remove(self):
"""
Remove interface from operating system. Removing the interface
diff --git a/python/vyos/ifconfig/bridge.py b/python/vyos/ifconfig/bridge.py
index 392718d9f..90c44af13 100644
--- a/python/vyos/ifconfig/bridge.py
+++ b/python/vyos/ifconfig/bridge.py
@@ -76,9 +76,6 @@ class BridgeIf(Interface):
'type': 'bridge',
}
- def __init__(self, ifname, **kargs):
- super().__init__(ifname, **kargs)
-
def set_ageing_time(self, time):
"""
Set bridge interface MAC address aging time in seconds. Internal kernel
diff --git a/python/vyos/ifconfig/dummy.py b/python/vyos/ifconfig/dummy.py
index 55935a16e..58b89fe68 100644
--- a/python/vyos/ifconfig/dummy.py
+++ b/python/vyos/ifconfig/dummy.py
@@ -27,6 +27,3 @@ class DummyIf(Interface):
default = {
'type': 'dummy',
}
-
- def __init__(self, ifname, **kargs):
- super().__init__(ifname, **kargs)
diff --git a/python/vyos/ifconfig/ethernet.py b/python/vyos/ifconfig/ethernet.py
index 9863ca826..8b6b6d9db 100644
--- a/python/vyos/ifconfig/ethernet.py
+++ b/python/vyos/ifconfig/ethernet.py
@@ -53,9 +53,6 @@ class EthernetIf(VLANIf):
'type': 'ethernet',
}
- def __init__(self, ifname, **kargs):
- super().__init__(ifname, **kargs)
-
def _delete(self):
# Ethernet interfaces can not be removed
pass
diff --git a/python/vyos/ifconfig/geneve.py b/python/vyos/ifconfig/geneve.py
index 46782a685..c6834fcd7 100644
--- a/python/vyos/ifconfig/geneve.py
+++ b/python/vyos/ifconfig/geneve.py
@@ -32,9 +32,6 @@ class GeneveIf(Interface):
'type': 'geneve',
}
- def __init__(self, ifname, **kargs):
- super().__init__(ifname, **kargs)
-
def _create(self):
cmd = 'ip link add name {} type geneve id {} remote {}' \
.format(self.config['ifname'], config['vni'], config['remote'])
diff --git a/python/vyos/ifconfig/l2tpv3.py b/python/vyos/ifconfig/l2tpv3.py
index 491fd24a7..a87535277 100644
--- a/python/vyos/ifconfig/l2tpv3.py
+++ b/python/vyos/ifconfig/l2tpv3.py
@@ -35,9 +35,6 @@ class L2TPv3If(Interface):
'type': 'l2tp',
}
- def __init__(self, ifname, **kargs):
- super().__init__(ifname, **kargs)
-
def _create(self):
# create tunnel interface
cmd = 'ip l2tp add tunnel tunnel_id {} '.format(config['tunnel_id'])
diff --git a/python/vyos/ifconfig/loopback.py b/python/vyos/ifconfig/loopback.py
index 410a19dcf..37b8e9e3b 100644
--- a/python/vyos/ifconfig/loopback.py
+++ b/python/vyos/ifconfig/loopback.py
@@ -27,9 +27,6 @@ class LoopbackIf(Interface):
'type': 'loopback',
}
- def __init__(self, ifname, **kargs):
- super().__init__(ifname, **kargs)
-
def remove(self):
"""
Loopback interface can not be deleted from operating system. We can
diff --git a/python/vyos/ifconfig/macvlan.py b/python/vyos/ifconfig/macvlan.py
index a86f84f3e..da3beea8b 100644
--- a/python/vyos/ifconfig/macvlan.py
+++ b/python/vyos/ifconfig/macvlan.py
@@ -27,9 +27,6 @@ class MACVLANIf(VLANIf):
'type': 'macvlan',
}
- def __init__(self, ifname, **kargs):
- super().__init__(ifname, **kargs)
-
def _create(self):
cmd = 'ip link add {ifname} link {link} type macvlan mode {mode}'.format(
**self.config)
diff --git a/python/vyos/ifconfig/vlan.py b/python/vyos/ifconfig/vlan.py
index ad5d066c4..4e0db83c7 100644
--- a/python/vyos/ifconfig/vlan.py
+++ b/python/vyos/ifconfig/vlan.py
@@ -30,9 +30,6 @@ class VLANIf(Interface):
'type': 'vlan',
}
- def __init__(self, ifname, **kargs):
- super().__init__(ifname, **kargs)
-
def remove(self):
"""
Remove interface from operating system. Removing the interface
diff --git a/python/vyos/ifconfig/vxlan.py b/python/vyos/ifconfig/vxlan.py
index 86702b2cd..f7a04d81b 100644
--- a/python/vyos/ifconfig/vxlan.py
+++ b/python/vyos/ifconfig/vxlan.py
@@ -50,9 +50,6 @@ class VXLANIf(Interface):
# the IANA's selection of a standard destination port
}
- def __init__(self, ifname, **kargs):
- super().__init__(ifname, **kargs)
-
def _create(self):
cmd = ''
if self.config['remote']:
diff --git a/python/vyos/ifconfig/wireguard.py b/python/vyos/ifconfig/wireguard.py
index 411c3e146..044041f68 100644
--- a/python/vyos/ifconfig/wireguard.py
+++ b/python/vyos/ifconfig/wireguard.py
@@ -54,9 +54,6 @@ class WireGuardIf(Interface):
'allowed-ips': [], 'pubkey': None, 'fwmark': 0, 'psk': '/dev/null'}
"""
- def __init__(self, ifname, **kargs):
- super().__init__(ifname, **kargs)
-
def update(self):
if not self.config['private-key']:
raise ValueError("private key required")