policy: T2425: add missing validator for large-community-lists

without the validators FRR commit errors would happen.

2 files changed, 51 insertions, 2 deletions

diff --git a/interface-definitions/policy.xml.in b/interface-definitions/policy.xml.in
index b3510a716..b5ea2058a 100644
--- a/interface-definitions/policy.xml.in
+++ b/interface-definitions/policy.xml.in
@@ -315,9 +315,17 @@
                 <properties>
                   <help>Regular expression to match against a large community list</help>
                   <valueHelp>
-                    <format>&lt;aa:nn:nn&gt;</format>
-                    <description>Large Community value</description>
+                    <format>ASN:NN:NN</format>
+                    <description>BGP large-community-list filter</description>
+                  </valueHelp>
+                  <valueHelp>
+                    <format>IP:NN:NN</format>
+                    <description>BGP large-community-list filter (IPv4 address format)</description>
                   </valueHelp>
+                  <constraint>
+                    <validator name="large-community-list"/>
+                  </constraint>
+                  <constraintErrorMessage>Malformed large-community-list</constraintErrorMessage>
                 </properties>
               </leafNode>
             </children>
diff --git a/src/validators/large-community-list b/src/validators/large-community-list
new file mode 100755
index 000000000..6c9a3a148
--- /dev/null
+++ b/src/validators/large-community-list
@@ -0,0 +1,41 @@
+#!/usr/bin/env python3
+#
+# Copyright (C) 2021 VyOS maintainers and contributors
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 2 or later as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+import re
+import sys
+
+from vyos.template import is_ipv4
+
+pattern = '(.*):(.*):(.*)'
+
+if __name__ == '__main__':
+    if len(sys.argv) != 2:
+        sys.exit(1)
+
+    value = sys.argv[1].split(':')
+    if not len(value) == 3:
+        sys.exit(1)
+
+    # Check if the first string is an IPv4 address
+    if is_ipv4(value[0]):
+        if value[1].isdigit() and value[2].isdigit():
+            sys.exit(0)
+    # If first string is not an IP address it must be a number
+    else:
+        if value[0].isdigit() and value[1].isdigit() and value[2].isdigit():
+            sys.exit(0)
+
+    sys.exit(1)