diff options
author | Christian Breunig <christian@breunig.cc> | 2024-01-21 20:01:28 +0100 |
---|---|---|
committer | Mergify <37929162+mergify[bot]@users.noreply.github.com> | 2024-01-22 12:18:43 +0000 |
commit | ca1ad197eb7f9cb8352747dd0ad078366154faaf (patch) | |
tree | 3edc0163477ad38acff90a7da6a4b9109c5f5b22 | |
parent | 7f7cf25cdd84da7c2b99c0913e5ba25d999b3978 (diff) | |
download | vyos-1x-ca1ad197eb7f9cb8352747dd0ad078366154faaf.tar.gz vyos-1x-ca1ad197eb7f9cb8352747dd0ad078366154faaf.zip |
ethernet: T4638: add smoketests verifying there are no stale VLAN interfaces left
This extends commit 7ba47f027 ("ethernet: T4638: deleting parent interface does
not delete underlying VIFs") with a smoketests ensure no VIFs are left behind.
(cherry picked from commit e390d0080d1a15b18ede49f1f2472ef940145c19)
-rwxr-xr-x | smoketest/scripts/cli/test_interfaces_ethernet.py | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/smoketest/scripts/cli/test_interfaces_ethernet.py b/smoketest/scripts/cli/test_interfaces_ethernet.py index a39b81348..e414f18cb 100755 --- a/smoketest/scripts/cli/test_interfaces_ethernet.py +++ b/smoketest/scripts/cli/test_interfaces_ethernet.py @@ -141,15 +141,18 @@ class EthernetInterfaceTest(BasicInterfaceTest.TestCase): # Verify that no address remains on the system as this is an eternal # interface. - for intf in self._interfaces: - self.assertNotIn(AF_INET, ifaddresses(intf)) + for interface in self._interfaces: + self.assertNotIn(AF_INET, ifaddresses(interface)) # required for IPv6 link-local address - self.assertIn(AF_INET6, ifaddresses(intf)) - for addr in ifaddresses(intf)[AF_INET6]: + self.assertIn(AF_INET6, ifaddresses(interface)) + for addr in ifaddresses(interface)[AF_INET6]: # checking link local addresses makes no sense if is_ipv6_link_local(addr['addr']): continue - self.assertFalse(is_intf_addr_assigned(intf, addr['addr'])) + self.assertFalse(is_intf_addr_assigned(interface, addr['addr'])) + # Ensure no VLAN interfaces are left behind + tmp = [x for x in Section.interfaces('ethernet') if x.startswith(f'{interface}.')] + self.assertListEqual(tmp, []) def test_offloading_rps(self): # enable RPS on all available CPUs, RPS works with a CPU bitmask, |