summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Poessinger <christian@poessinger.com>2022-12-30 19:14:30 +0100
committerGitHub <noreply@github.com>2022-12-30 19:14:30 +0100
commitf93896016d15ee68e0f319028ecb6960d16e3bff (patch)
tree1dd678e67f94049a7d28ea0ac6ef586455ad19ce
parent3abec988c44e8e211b91caf504bb6a756668791a (diff)
parent355db68b5a13ec56d1949066bc44bcf2d4261213 (diff)
downloadvyos-1x-f93896016d15ee68e0f319028ecb6960d16e3bff.tar.gz
vyos-1x-f93896016d15ee68e0f319028ecb6960d16e3bff.zip
Merge pull request #1726 from vfreex/vxlan-fix-rebuild
T4897: vxlan: Fix setting `source-address` and `source-interface`
-rwxr-xr-xsrc/conf_mode/interfaces-vxlan.py8
1 files changed, 3 insertions, 5 deletions
diff --git a/src/conf_mode/interfaces-vxlan.py b/src/conf_mode/interfaces-vxlan.py
index af2d0588d..b1536148c 100755
--- a/src/conf_mode/interfaces-vxlan.py
+++ b/src/conf_mode/interfaces-vxlan.py
@@ -52,13 +52,11 @@ def get_config(config=None):
# VXLAN interfaces are picky and require recreation if certain parameters
# change. But a VXLAN interface should - of course - not be re-created if
# it's description or IP address is adjusted. Feels somehow logic doesn't it?
- for cli_option in ['external', 'gpe', 'group', 'port', 'remote',
+ for cli_option in ['parameters', 'external', 'gpe', 'group', 'port', 'remote',
'source-address', 'source-interface', 'vni']:
- if leaf_node_changed(conf, base + [ifname, cli_option]):
+ if is_node_changed(conf, base + [ifname, cli_option]):
vxlan.update({'rebuild_required': {}})
-
- if is_node_changed(conf, base + [ifname, 'parameters']):
- vxlan.update({'rebuild_required': {}})
+ break
# We need to verify that no other VXLAN tunnel is configured when external
# mode is in use - Linux Kernel limitation