diff options
| author | Christian Poessinger <christian@poessinger.com> | 2020-12-20 16:31:06 +0100 |
|---|---|---|
| committer | Christian Poessinger <christian@poessinger.com> | 2020-12-20 17:04:51 +0100 |
| commit | 34437ff4dee5fb9fb70bbc7c8b83ecb074793770 (patch) | |
| tree | 393740eec9b178de1eefa310216154d6e2d4fa46 | |
| parent | c8551d473b12c44b5bbb9d9e9d7921410eb55a5b (diff) | |
| download | vyos-1x-34437ff4dee5fb9fb70bbc7c8b83ecb074793770.tar.gz vyos-1x-34437ff4dee5fb9fb70bbc7c8b83ecb074793770.zip | |
smoktest: interface: disable base mirror test
One should not use hardcoded interfaces in this base class, rather rely on
self._options like every other test. This implementation breaks on my development
system ans also deletes my OSPF dummy mgmt interface :(.
| -rw-r--r-- | smoketest/scripts/cli/base_interfaces_test.py | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/smoketest/scripts/cli/base_interfaces_test.py b/smoketest/scripts/cli/base_interfaces_test.py index d08dff82c..f8e9835af 100644 --- a/smoketest/scripts/cli/base_interfaces_test.py +++ b/smoketest/scripts/cli/base_interfaces_test.py @@ -101,15 +101,19 @@ class BasicInterfaceTest: del self.session def test_mirror(self): + # Test is disabled as it contains hardcoded bond interfaces which will + # screw up all kinds of live deployments. + return None if self._test_mirror: - # Create test dependency interface self.session.set(['interfaces','dummy','dum0']) self.session.set(['interfaces','dummy','dum1']) self.session.set(['interfaces','bonding','bond1','member','interface','dum0']) self.session.set(['interfaces','bonding','bond1','member','interface','dum1']) + # ^- WHY? There is self._options for that :( + Success = 0 i = 0 # Check the two-way mirror rules of ingress and egress @@ -127,8 +131,6 @@ class BasicInterfaceTest: i=0 self.session.delete(['interfaces','dummy']) self.session.delete(['interfaces','bonding']) - else: - return None def test_add_description(self): |