summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniil Baturin <daniil@vyos.io>2024-04-24 21:22:16 +0200
committerGitHub <noreply@github.com>2024-04-24 21:22:16 +0200
commit018b940f685b01a9765657ec25724853cff25188 (patch)
tree56c4b960e0fec3548f3fc349c1196a17af6d248e
parentc1b328f6818b0ff7e4739ea04572bf4da884f134 (diff)
parent9bdc522e2dbf3208a6f4c1b0c098b8dc57cf0dd6 (diff)
downloadvyos-1x-018b940f685b01a9765657ec25724853cff25188.tar.gz
vyos-1x-018b940f685b01a9765657ec25724853cff25188.zip
Merge pull request #3360 from vyos/mergify/bp/sagitta/pr-3359
T5833: Not all AFIs compatible with VRF add verify check (backport #3359)
-rwxr-xr-xsrc/conf_mode/protocols_bgp.py16
1 files changed, 16 insertions, 0 deletions
diff --git a/src/conf_mode/protocols_bgp.py b/src/conf_mode/protocols_bgp.py
index 2b16de775..4df97d133 100755
--- a/src/conf_mode/protocols_bgp.py
+++ b/src/conf_mode/protocols_bgp.py
@@ -473,6 +473,22 @@ def verify(bgp):
if peer_group_as is None or (peer_group_as != 'internal' and peer_group_as != bgp['system_as']):
raise ConfigError('route-reflector-client only supported for iBGP peers')
+ # T5833 not all AFIs are supported for VRF
+ if 'vrf' in bgp and 'address_family' in peer_config:
+ unsupported_vrf_afi = {
+ 'ipv4_flowspec',
+ 'ipv6_flowspec',
+ 'ipv4_labeled_unicast',
+ 'ipv6_labeled_unicast',
+ 'ipv4_vpn',
+ 'ipv6_vpn',
+ }
+ for afi in peer_config['address_family']:
+ if afi in unsupported_vrf_afi:
+ raise ConfigError(
+ f"VRF is not allowed for address-family '{afi.replace('_', '-')}'"
+ )
+
# Throw an error if a peer group is not configured for allow range
for prefix in dict_search('listen.range', bgp) or []:
# we can not use dict_search() here as prefix contains dots ...