summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Mangin <thomas.mangin@exa.net.uk>2020-04-23 14:39:48 +0100
committerThomas Mangin <thomas.mangin@exa.net.uk>2020-04-23 14:39:48 +0100
commit15d51e0306f3987437f0c4626a396b8ddd4ec646 (patch)
treebb4e3b90bc20a238f7abe4a36569e484fcc8ccf4
parent247577917639c279993e451b210d38e393630c36 (diff)
downloadvyos-1x-15d51e0306f3987437f0c4626a396b8ddd4ec646.tar.gz
vyos-1x-15d51e0306f3987437f0c4626a396b8ddd4ec646.zip
l2tpv3: T2352: check that the local-ip exists
-rwxr-xr-xsrc/conf_mode/interfaces-l2tpv3.py5
1 files changed, 4 insertions, 1 deletions
diff --git a/src/conf_mode/interfaces-l2tpv3.py b/src/conf_mode/interfaces-l2tpv3.py
index 8312d6f37..5e495dd4b 100755
--- a/src/conf_mode/interfaces-l2tpv3.py
+++ b/src/conf_mode/interfaces-l2tpv3.py
@@ -24,7 +24,7 @@ from vyos.config import Config
from vyos.ifconfig import L2TPv3If, Interface
from vyos import ConfigError
from vyos.util import call
-from vyos.validate import is_bridge_member
+from vyos.validate import is_bridge_member, is_addr_assigned
default_config_data = {
'address': [],
@@ -170,6 +170,9 @@ def verify(l2tpv3):
if not l2tpv3['local_address']:
raise ConfigError(f'Must configure the l2tpv3 local-ip for {interface}')
+ if not is_addr_assigned(l2tpv3['local_address']):
+ raise ConfigError(f'Must use a configured IP on l2tpv3 local-ip for {interface}')
+
if not l2tpv3['remote_address']:
raise ConfigError(f'Must configure the l2tpv3 remote-ip for {interface}')