summaryrefslogtreecommitdiff
path: root/data/templates
diff options
context:
space:
mode:
authorIndrajit Raychaudhuri <irc@indrajit.com>2023-11-08 14:11:04 -0600
committerIndrajit Raychaudhuri <irc@indrajit.com>2023-11-08 16:40:34 -0600
commit9efa76910458b6d58882768641ab598b7c0c9699 (patch)
treecb0074939bb9d01b74ef3a1b7fdfff4b53ef2e4b /data/templates
parentb083e1bbf230d4e407bd9adb508197517d15bfb1 (diff)
downloadvyos-1x-9efa76910458b6d58882768641ab598b7c0c9699.tar.gz
vyos-1x-9efa76910458b6d58882768641ab598b7c0c9699.zip
ddclient: T5708: Ensure password is always wrapped in quotes
Migration to 3.11.1 follow-up: This should make `ddclient.conf` parsing more resilient to edge cases (particularly when `password` isn't the last option right before the host parameter). ddclient config parser applies special treatment to the password field and would unwrap the quotes automatically. Also, switch from now deprecated `use=no` to `use=disabled`.
Diffstat (limited to 'data/templates')
-rw-r--r--data/templates/dns-dynamic/ddclient.conf.j26
1 files changed, 3 insertions, 3 deletions
diff --git a/data/templates/dns-dynamic/ddclient.conf.j2 b/data/templates/dns-dynamic/ddclient.conf.j2
index 879887a1f..356b8d0d0 100644
--- a/data/templates/dns-dynamic/ddclient.conf.j2
+++ b/data/templates/dns-dynamic/ddclient.conf.j2
@@ -13,9 +13,9 @@ web-skip{{ ipv }}='{{ web_options.skip }}', \
if{{ ipv }}={{ address }}, \
{% endif %}
{% endfor %}
-{# Other service options #}
+{# Other service options with special treatment for password #}
{% for k,v in kwargs.items() if v is vyos_defined %}
-{{ k | replace('_', '-') }}={{ v }}{{ ',' if not loop.last }} \
+{{ k | replace('_', '-') }}={{ "'%s'" % (v) if k == 'password' else v }}{{ ',' if not loop.last }} \
{% endfor %}
{# Actual hostname for the service #}
{{ host }}
@@ -29,7 +29,7 @@ cache={{ config_file | replace('.conf', '.cache') }}
{# ddclient default (web=dyndns) doesn't support ssl and results in process lockup #}
web=googledomains
{# ddclient default (use=ip) results in confusing warning message in log #}
-use=no
+use=disabled
{% if address is vyos_defined %}
{% for address, service_cfg in address.items() %}