diff options
| author | Christian Poessinger <christian@poessinger.com> | 2022-02-24 22:47:12 +0100 | 
|---|---|---|
| committer | Christian Poessinger <christian@poessinger.com> | 2022-02-24 22:47:12 +0100 | 
| commit | a68c9238111c6caee78bb28f8054b8f0cfa0e374 (patch) | |
| tree | f3d2ce8e1e6dd4f8c7987685fd2c155c7813e266 /interface-definitions/include/snmp/access-mode.xml.i | |
| parent | 53517de05e9566c35218d1f07cacb1bff98a46d9 (diff) | |
| download | vyos-1x-a68c9238111c6caee78bb28f8054b8f0cfa0e374.tar.gz vyos-1x-a68c9238111c6caee78bb28f8054b8f0cfa0e374.zip | |
scripts: T4269: node.def generator should automatically add default values
Since introducing the XML <defaultValue> node it was common, but redundant,
practice to also add a help string indicating which value would be used as
default if the node is unset.
This makes no sense b/c it's duplicated code/value/characters and prone to
error. The node.def scripts should be extended to automatically render the
appropriate default value into the CLI help string.
For e.g. SSH the current PoC renders:
$ cat templates-cfg/service/ssh/port/node.def
  multi:
  type: txt
  help: Port for SSH service (default: 22)
  val_help: u32:1-65535; Numeric IP port
  ...
Not all subsystems are already migrated to get_config_dict() and make use of
the defaults() call - those subsystems need to be migrated, first before the new
default is added to the CLI help.
Diffstat (limited to 'interface-definitions/include/snmp/access-mode.xml.i')
| -rw-r--r-- | interface-definitions/include/snmp/access-mode.xml.i | 2 | 
1 files changed, 1 insertions, 1 deletions
| diff --git a/interface-definitions/include/snmp/access-mode.xml.i b/interface-definitions/include/snmp/access-mode.xml.i index 1fce2364e..71c766774 100644 --- a/interface-definitions/include/snmp/access-mode.xml.i +++ b/interface-definitions/include/snmp/access-mode.xml.i @@ -7,7 +7,7 @@      </completionHelp>      <valueHelp>        <format>ro</format> -      <description>Read-Only (default)</description> +      <description>Read-Only</description>      </valueHelp>      <valueHelp>        <format>rw</format> | 
