diff options
| author | Kyrylo Yatsenko <hedrok@gmail.com> | 2026-01-08 14:50:51 +0200 |
|---|---|---|
| committer | Kyrylo Yatsenko <hedrok@gmail.com> | 2026-01-09 13:03:15 +0200 |
| commit | 5310713bf116b8ad65f9e86346a7c02b2922212e (patch) | |
| tree | b6b9112772651a3f87da931740f61ed04ec554bb /interface-definitions/include | |
| parent | 041b990ae1662b4ac7fe2fc4b62e1f624f5d6c9a (diff) | |
| download | vyos-1x-5310713bf116b8ad65f9e86346a7c02b2922212e.tar.gz vyos-1x-5310713bf116b8ad65f9e86346a7c02b2922212e.zip | |
isis: T8158: fix lsp-timers
There are three configuration values in VyOS isis XML:
* lsp-gen-interval
* lsp-refresh-interval
* max-lsp-lifetime
In FRR they have the following restrictions in yang model:
* refresh-interval, default 900
* maximum-lifetime >= refresh-interval + 300 (350-65535), default 1200
* generation-interval < refresh-interval (1..120), default 30
When setting these values in separate steps we can get error e.g.:
libyang: Must condition ". >= ../refresh-interval + 300" not satisfied.
even when all restrictions are satisfied.
To fix the issue:
1. Write default values in our XML.
2. Check these restrictions in protocol_isis.py
3. Use FRR command `lsp-timers` that sets all these values in one go
Diffstat (limited to 'interface-definitions/include')
| -rw-r--r-- | interface-definitions/include/isis/protocol-common-config.xml.i | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/interface-definitions/include/isis/protocol-common-config.xml.i b/interface-definitions/include/isis/protocol-common-config.xml.i index 459a048a2..45c048b8a 100644 --- a/interface-definitions/include/isis/protocol-common-config.xml.i +++ b/interface-definitions/include/isis/protocol-common-config.xml.i @@ -98,6 +98,7 @@ <validator name="numeric" argument="--range 1-120"/> </constraint> </properties> + <defaultValue>30</defaultValue> </leafNode> <leafNode name="lsp-mtu"> <properties> @@ -116,13 +117,14 @@ <properties> <help>LSP refresh interval</help> <valueHelp> - <format>u32:1-65235</format> + <format>u32:2-65235</format> <description>LSP refresh interval in seconds</description> </valueHelp> <constraint> - <validator name="numeric" argument="--range 1-65235"/> + <validator name="numeric" argument="--range 2-65235"/> </constraint> </properties> + <defaultValue>900</defaultValue> </leafNode> <leafNode name="max-lsp-lifetime"> <properties> @@ -135,6 +137,7 @@ <validator name="numeric" argument="--range 1-65535"/> </constraint> </properties> + <defaultValue>1200</defaultValue> </leafNode> <leafNode name="metric-style"> <properties> |