diff options
| author | Christian Poessinger <christian@poessinger.com> | 2020-07-01 19:06:52 +0200 |
|---|---|---|
| committer | Christian Poessinger <christian@poessinger.com> | 2020-07-25 15:35:33 +0200 |
| commit | ebefa38b9fa946fde82a4c9b55122c037598143b (patch) | |
| tree | 8090cf3bb0401f445335e930d4643fbe6e3d4a00 /interface-definitions | |
| parent | 6d2ffb9badcd15d431b8bbb6b28d2171d06e6dc4 (diff) | |
| download | vyos-1x-ebefa38b9fa946fde82a4c9b55122c037598143b.tar.gz vyos-1x-ebefa38b9fa946fde82a4c9b55122c037598143b.zip | |
ethernet: ifconfig: T2653: move to get_config_dict()
The current VyOS CLI parser code written in Python contains a ton of duplicates
which I can also hold myself accountable for - or maybe mainly me - depends on
the angle of judge.
While providing a new update() method in vyos.ifconfig.interfaces() this is
extended for ethernet based interfaces which also supports 802.1q, 802.1ad
VLANs. This commit migrates the existing codebase for an ethernet based
interfaces and implements the missing parts for VLANs. Adding or migrating other
interfaces (e.g. bridge or bond) will become much easier as they must reuse
the entire functionality - we now walk towards a single codepath.
Thanks for all who made this combined effort possible!
Signed-off-by: Christian Poessinger <christian@poessinger.com>
Diffstat (limited to 'interface-definitions')
| -rw-r--r-- | interface-definitions/interfaces-ethernet.xml.in | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/interface-definitions/interfaces-ethernet.xml.in b/interface-definitions/interfaces-ethernet.xml.in index 1e32a15f8..e8f3f09f1 100644 --- a/interface-definitions/interfaces-ethernet.xml.in +++ b/interface-definitions/interfaces-ethernet.xml.in @@ -56,6 +56,7 @@ </constraint> <constraintErrorMessage>duplex must be auto, half or full</constraintErrorMessage> </properties> + <defaultValue>auto</defaultValue> </leafNode> #include <include/interface-hw-id.xml.i> <node name="ip"> @@ -265,6 +266,7 @@ </constraint> <constraintErrorMessage>Speed must be auto, 10, 100, 1000, 2500, 5000, 10000, 25000, 40000, 50000 or 100000</constraintErrorMessage> </properties> + <defaultValue>auto</defaultValue> </leafNode> #include <include/vif-s.xml.i> #include <include/vif.xml.i> |