diff options
| author | Christian Poessinger <christian@poessinger.com> | 2021-12-25 22:57:59 +0100 |
|---|---|---|
| committer | Christian Poessinger <christian@poessinger.com> | 2021-12-25 23:27:15 +0100 |
| commit | b9b5070203c3c3b31a7b297c5ddba8934b1ca34d (patch) | |
| tree | 4d630ee9e08f2dfb425cab130ab9bc5c8d632740 /interface-definitions | |
| parent | 0030f9fc844036a0d1a0381a9096b1b9d368e35f (diff) | |
| download | vyos-1x-b9b5070203c3c3b31a7b297c5ddba8934b1ca34d.tar.gz vyos-1x-b9b5070203c3c3b31a7b297c5ddba8934b1ca34d.zip | |
flow-accounting: T4105: drop "sflow agent-address auto"
The implementation of the "auto" option to specify the sflow/netflow
agent-address is very error prone. The current implementation will determine
the IP address used for the "auto" value as follow:
Get BGP router-id
1) If not found use OSPF router-id
2) If not found use OSPFv3 router-id
3) If not found use "the first IP address found on the system
Well, what is the "first IP address found"? Also this changes if DHCP is in use.
Also another disadvantage is when the BGP/OSPF/OSPFv3 router-id is changed,
the agent-address is not updated upon the next reboot of the system.
This task is about removing the "auto" keyword from the CLI at all and make it
either entirely configurable by the user and hardcode the value in CLI, or not
use this at all.
If "auto" is specified we will query the system in the above order and set the
proper router-id in the CLI. If none can be found the CLI node is removed.
Diffstat (limited to 'interface-definitions')
| -rw-r--r-- | interface-definitions/flow-accounting-conf.xml.in | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/interface-definitions/flow-accounting-conf.xml.in b/interface-definitions/flow-accounting-conf.xml.in index 7b110e733..ba5c70979 100644 --- a/interface-definitions/flow-accounting-conf.xml.in +++ b/interface-definitions/flow-accounting-conf.xml.in @@ -363,19 +363,13 @@ <script>${vyos_completion_dir}/list_local_ips.sh --ipv4</script> </completionHelp> <valueHelp> - <format>auto</format> - <description>auto select sFlow agent-address (default)</description> - </valueHelp> - <valueHelp> <format>ipv4</format> <description>sFlow IPv4 agent address</description> </valueHelp> <constraint> <validator name="ipv4-address"/> - <regex>^auto$</regex> </constraint> </properties> - <defaultValue>auto</defaultValue> </leafNode> <leafNode name="sampling-rate"> <properties> |