diff options
| author | Ruben Herold <ruben@puettmann.net> | 2026-09-04 11:03:16 +0200 |
|---|---|---|
| committer | Viacheslav Hletenko <seversss265@gmail.com> | 2026-10-15 16:05:57 +0300 |
| commit | da0bea0d10020bfd76d2f763965947db905cab9b (patch) | |
| tree | 70c669984bda7f78054abd6833475991623077ee /interface-definitions | |
| parent | 579fc38cea44993318a429e195ba74b1081fbcc1 (diff) | |
| download | vyos-1x-da0bea0d10020bfd76d2f763965947db905cab9b.tar.gz vyos-1x-da0bea0d10020bfd76d2f763965947db905cab9b.zip | |
dhcp-server: T9267: drop standalone substring "length" option
The byte length compared by a hostname/vendor-class-id "substring"
match is always derived from "value" for a meaningful equality test:
a shorter length never matches (comparing fewer option bytes against
the full value literal), and a longer one is silently clamped by Kea
to the available bytes, turning what looks like a prefix match into
an exact match of the whole remainder. There is no legitimate use for
setting it independently of "value", so drop the leaf rather than add
another verify() constraint around it.
Reported by alexk37 in review of PR #5436.
Diffstat (limited to 'interface-definitions')
| -rw-r--r-- | interface-definitions/include/dhcp/dhcp-server-common-config.xml.i | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/interface-definitions/include/dhcp/dhcp-server-common-config.xml.i b/interface-definitions/include/dhcp/dhcp-server-common-config.xml.i index 60ba1f952..e909adca3 100644 --- a/interface-definitions/include/dhcp/dhcp-server-common-config.xml.i +++ b/interface-definitions/include/dhcp/dhcp-server-common-config.xml.i @@ -77,18 +77,6 @@ </constraint> </properties> </leafNode> - <leafNode name="length"> - <properties> - <help>Number of bytes to compare (default: length of value)</help> - <valueHelp> - <format>u32:1-255</format> - <description>Byte length</description> - </valueHelp> - <constraint> - <validator name="numeric" argument="--range 1-255"/> - </constraint> - </properties> - </leafNode> <leafNode name="value"> <properties> <help>Filters on part of the option contents</help> @@ -141,18 +129,6 @@ </constraint> </properties> </leafNode> - <leafNode name="length"> - <properties> - <help>Number of bytes to compare (default: length of value)</help> - <valueHelp> - <format>u32:1-255</format> - <description>Byte length</description> - </valueHelp> - <constraint> - <validator name="numeric" argument="--range 1-255"/> - </constraint> - </properties> - </leafNode> <leafNode name="value"> <properties> <help>Filters on part of the option contents</help> |