diff options
| author | Christian Breunig <christian@breunig.cc> | 2023-01-23 17:45:20 +0100 |
|---|---|---|
| committer | Christian Breunig <christian@breunig.cc> | 2023-01-23 17:46:14 +0100 |
| commit | 36adc975316b8511c53c813b7542196e3d2779a8 (patch) | |
| tree | 0beeaaca7e6d473765c4e16761ad79ae8a8394cb /op-mode-definitions/show-interfaces-wireless.xml.in | |
| parent | cf78cac4757ceaca59ace03ad9a6a98f5746f223 (diff) | |
| download | vyos-1x-36adc975316b8511c53c813b7542196e3d2779a8.tar.gz vyos-1x-36adc975316b8511c53c813b7542196e3d2779a8.zip | |
op-mode: T4952: improve interface completion helper CLI experience
There are currently two ways to generate the interface name completion helper
list (we use openvpn in this example)
- <script> ${vyos_completion_dir}/list_interfaces.py --type openvpn</script>
- <path>interfaces openvpn</path>
The first one using <script> tends to be rather slow as there is a Python
interpreter startup involved (expensive). The latter simply calls a C program
which is executed rather fast and gives the same result.
We can simply replace the first call with the second one to make the CLI
feel faster.
Diffstat (limited to 'op-mode-definitions/show-interfaces-wireless.xml.in')
| -rw-r--r-- | op-mode-definitions/show-interfaces-wireless.xml.in | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/op-mode-definitions/show-interfaces-wireless.xml.in b/op-mode-definitions/show-interfaces-wireless.xml.in index b0a272225..cdd591f82 100644 --- a/op-mode-definitions/show-interfaces-wireless.xml.in +++ b/op-mode-definitions/show-interfaces-wireless.xml.in @@ -28,7 +28,7 @@ <properties> <help>Show specified wireless interface information</help> <completionHelp> - <script>${vyos_completion_dir}/list_interfaces.py --type wireless</script> + <path>interfaces wireless</path> </completionHelp> </properties> <command>${vyos_op_scripts_dir}/interfaces.py show --intf_name="$4" --intf_type=wireless</command> |