summaryrefslogtreecommitdiff
path: root/python
diff options
context:
space:
mode:
authorChristian Poessinger <christian@poessinger.com>2021-09-10 16:45:30 +0200
committerChristian Poessinger <christian@poessinger.com>2021-09-10 17:01:21 +0200
commitcc313b32ef26141c2c027e8543f78da1231cada2 (patch)
tree10a9f39dde08d5b3167dae183b00ba3c171af073 /python
parent310eb1b527047211ae236c6415fee51f15a0fa57 (diff)
downloadvyos-1x-cc313b32ef26141c2c027e8543f78da1231cada2.tar.gz
vyos-1x-cc313b32ef26141c2c027e8543f78da1231cada2.zip
ethernet: T3802: check if driver supports changing flow-control settings
(cherry picked from commit 1572edd2cef355710d1129907d3e49451a6c31d4)
Diffstat (limited to 'python')
-rw-r--r--python/vyos/ethtool.py2
-rw-r--r--python/vyos/ifconfig/ethernet.py5
2 files changed, 3 insertions, 4 deletions
diff --git a/python/vyos/ethtool.py b/python/vyos/ethtool.py
index 609d83b5e..7e46969cf 100644
--- a/python/vyos/ethtool.py
+++ b/python/vyos/ethtool.py
@@ -46,7 +46,7 @@ class Ethtool:
_ring_buffers_max = { }
_driver_name = None
_auto_negotiation = None
- _flow_control = None
+ _flow_control = False
_flow_control_enabled = None
def __init__(self, ifname):
diff --git a/python/vyos/ifconfig/ethernet.py b/python/vyos/ifconfig/ethernet.py
index 7bd269491..c4dfc7198 100644
--- a/python/vyos/ifconfig/ethernet.py
+++ b/python/vyos/ifconfig/ethernet.py
@@ -115,11 +115,10 @@ class EthernetIf(Interface):
if enable not in ['on', 'off']:
raise ValueError("Value out of range")
- driver_name = self.get_driver_name()
- if driver_name in ['vmxnet3', 'virtio_net', 'xen_netfront']:
+ if not self.ethtool.check_flow_control():
self._debug_msg(f'{driver_name} driver does not support changing '\
'flow control settings!')
- return
+ return False
current = self.ethtool.get_flow_control()
if current != enable: