diff options
| author | Christian Breunig <christian@breunig.cc> | 2023-10-19 19:02:51 +0200 |
|---|---|---|
| committer | Mergify <37929162+mergify[bot]@users.noreply.github.com> | 2023-10-19 18:10:41 +0000 |
| commit | a551d6e9f5fea5090bb0ff52e5721103ef990fb9 (patch) | |
| tree | 17d1a680b06c048d477da32bccc4da537d07c7da /python | |
| parent | e619b23b8889543465b61eb00d5b0d3c8063ae95 (diff) | |
| download | vyos-1x-a551d6e9f5fea5090bb0ff52e5721103ef990fb9.tar.gz vyos-1x-a551d6e9f5fea5090bb0ff52e5721103ef990fb9.zip | |
vyos.configdict: T5670: move from str to list when calling conf.exists()
We have had a mix of both string and list arguments to conf.exists(),
stremaline this to only make use of list calls.
(cherry picked from commit 3f17de7c32621353b51f782ca889a83cad7a6cfd)
Diffstat (limited to 'python')
| -rw-r--r-- | python/vyos/configdict.py | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/python/vyos/configdict.py b/python/vyos/configdict.py index 71a06b625..075ffe466 100644 --- a/python/vyos/configdict.py +++ b/python/vyos/configdict.py @@ -258,10 +258,10 @@ def has_address_configured(conf, intf): old_level = conf.get_level() conf.set_level([]) - intfpath = 'interfaces ' + Section.get_config_path(intf) - if ( conf.exists(f'{intfpath} address') or - conf.exists(f'{intfpath} ipv6 address autoconf') or - conf.exists(f'{intfpath} ipv6 address eui64') ): + intfpath = ['interfaces', Section.get_config_path(intf)] + if (conf.exists([intfpath, 'address']) or + conf.exists([intfpath, 'ipv6', 'address', 'autoconf']) or + conf.exists([intfpath, 'ipv6', 'address', 'eui64'])): ret = True conf.set_level(old_level) @@ -279,8 +279,7 @@ def has_vrf_configured(conf, intf): old_level = conf.get_level() conf.set_level([]) - tmp = ['interfaces', Section.get_config_path(intf), 'vrf'] - if conf.exists(tmp): + if conf.exists(['interfaces', Section.get_config_path(intf), 'vrf']): ret = True conf.set_level(old_level) @@ -298,8 +297,7 @@ def has_vlan_subinterface_configured(conf, intf): ret = False intfpath = ['interfaces', Section.section(intf), intf] - if ( conf.exists(intfpath + ['vif']) or - conf.exists(intfpath + ['vif-s'])): + if (conf.exists(intfpath + ['vif']) or conf.exists(intfpath + ['vif-s'])): ret = True return ret |