smoketest: refactor setUp() for all interface based testcases

It does not make sense (at all!) to re-initialize the entire class with every
call to setUp(). We neither change the enabled/disabled tastcases dynamically,
not do we adjust the testinterfaces during a run.

Remove the runtime overhead and place one-time init calls into setUpClass()
instead.

1 files changed, 17 insertions, 18 deletions

diff --git a/smoketest/scripts/cli/test_interfaces_bridge.py b/smoketest/scripts/cli/test_interfaces_bridge.py
index 33c2e7dad..f64b527b3 100755
--- a/smoketest/scripts/cli/test_interfaces_bridge.py
+++ b/smoketest/scripts/cli/test_interfaces_bridge.py
@@ -28,31 +28,30 @@ from vyos.util import read_file
 from vyos.validate import is_intf_addr_assigned
 
 class BridgeInterfaceTest(BasicInterfaceTest.BaseTest):
-    def setUp(self):
-        self._test_ip = True
-        self._test_ipv6 = True
-        self._test_ipv6_pd = True
-        self._test_ipv6_dhcpc6 = True
-        self._test_vlan = True
-        self._base_path = ['interfaces', 'bridge']
-        self._mirror_interfaces = ['dum21354']
-        self._members = []
+    @classmethod
+    def setUpClass(cls):
+        cls._test_ip = True
+        cls._test_ipv6 = True
+        cls._test_ipv6_pd = True
+        cls._test_ipv6_dhcpc6 = True
+        cls._test_vlan = True
+        cls._base_path = ['interfaces', 'bridge']
+        cls._mirror_interfaces = ['dum21354']
+        cls._members = []
 
         # we need to filter out VLAN interfaces identified by a dot (.)
         # in their name - just in case!
         if 'TEST_ETH' in os.environ:
-            self._members = os.environ['TEST_ETH'].split()
+            cls._members = os.environ['TEST_ETH'].split()
         else:
-            for tmp in Section.interfaces("ethernet"):
+            for tmp in Section.interfaces('ethernet'):
                 if not '.' in tmp:
-                    self._members.append(tmp)
+                    cls._members.append(tmp)
 
-        self._options['br0'] = []
-        for member in self._members:
-            self._options['br0'].append(f'member interface {member}')
-        self._interfaces = list(self._options)
-
-        super().setUp()
+        cls._options['br0'] = []
+        for member in cls._members:
+            cls._options['br0'].append(f'member interface {member}')
+        cls._interfaces = list(cls._options)
 
     def tearDown(self):
         for intf in self._interfaces: