summaryrefslogtreecommitdiff
path: root/smoketest/scripts/cli/test_interfaces_pppoe.py
diff options
context:
space:
mode:
authorChristian Breunig <christian@breunig.cc>2024-04-06 12:55:00 +0200
committerGitHub <noreply@github.com>2024-04-06 12:55:00 +0200
commit4f8eeee98e4929cecc601e10c460bb476165ce21 (patch)
tree3cfec756286c7dc4614686d391ecf7c2d2cc1fdc /smoketest/scripts/cli/test_interfaces_pppoe.py
parent4c5afe0ba7853cf3fc4626933ecde70b321e9d67 (diff)
parentd9d2e9c8ead29c173fefd1b565d191a85baaa071 (diff)
downloadvyos-1x-4f8eeee98e4929cecc601e10c460bb476165ce21.tar.gz
vyos-1x-4f8eeee98e4929cecc601e10c460bb476165ce21.zip
Merge pull request #3266 from c-po/spring-cleaning-4
T6199: start validating smoketests against real CLI defaultValues
Diffstat (limited to 'smoketest/scripts/cli/test_interfaces_pppoe.py')
-rwxr-xr-xsmoketest/scripts/cli/test_interfaces_pppoe.py7
1 files changed, 4 insertions, 3 deletions
diff --git a/smoketest/scripts/cli/test_interfaces_pppoe.py b/smoketest/scripts/cli/test_interfaces_pppoe.py
index e99d8b3d1..2683a3122 100755
--- a/smoketest/scripts/cli/test_interfaces_pppoe.py
+++ b/smoketest/scripts/cli/test_interfaces_pppoe.py
@@ -1,6 +1,6 @@
#!/usr/bin/env python3
#
-# Copyright (C) 2019-2023 VyOS maintainers and contributors
+# Copyright (C) 2019-2024 VyOS maintainers and contributors
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License version 2 or later as
@@ -20,6 +20,7 @@ from psutil import process_iter
from base_vyostest_shim import VyOSUnitTestSHIM
from vyos.configsession import ConfigSessionError
+from vyos.xml_ref import default_value
config_file = '/etc/ppp/peers/{}'
base_path = ['interfaces', 'pppoe']
@@ -169,10 +170,10 @@ class PPPoEInterfaceTest(VyOSUnitTestSHIM.TestCase):
for interface in self._interfaces:
user = f'VyOS-user-{interface}'
passwd = f'VyOS-passwd-{interface}'
+ mtu_default = default_value(base_path + [interface, 'mtu'])
- # verify "normal" PPPoE value - 1492 is default MTU
tmp = get_config_value(interface, 'mtu')[1]
- self.assertEqual(tmp, '1492')
+ self.assertEqual(tmp, mtu_default)
tmp = get_config_value(interface, 'user')[1].replace('"', '')
self.assertEqual(tmp, user)
tmp = get_config_value(interface, 'password')[1].replace('"', '')