diff options
| author | Christian Breunig <christian@breunig.cc> | 2023-12-24 10:17:20 +0100 |
|---|---|---|
| committer | Mergify <37929162+mergify[bot]@users.noreply.github.com> | 2023-12-24 16:40:10 +0000 |
| commit | cddd596a0e03a0ecbbe63bba4f64e9932d02d01f (patch) | |
| tree | 306032c313424baf7f1a741d43ffde76298ef5ee /src/conf_mode/firewall.py | |
| parent | 50ec7b3cd28d1dec1592a141f4eaf2e5c7082ba3 (diff) | |
| download | vyos-1x-cddd596a0e03a0ecbbe63bba4f64e9932d02d01f.tar.gz vyos-1x-cddd596a0e03a0ecbbe63bba4f64e9932d02d01f.zip | |
T5837: cleanup use of calls to vyos.configdict.node_changed()
node_changed() will return a list of changed keys under "path". We are not
always interested what changed, sometimes we are only interested if something
changed at all, that what vyos.configdict.is_node_changed() is for.
(cherry picked from commit 5e7a8288d06a6d6beee5e1abd2e06698ab778650)
Diffstat (limited to 'src/conf_mode/firewall.py')
| -rwxr-xr-x | src/conf_mode/firewall.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/conf_mode/firewall.py b/src/conf_mode/firewall.py index 1cc146edd..1d33cb52d 100755 --- a/src/conf_mode/firewall.py +++ b/src/conf_mode/firewall.py @@ -23,7 +23,7 @@ from sys import exit from vyos.base import Warning from vyos.config import Config -from vyos.configdict import node_changed +from vyos.configdict import is_node_changed from vyos.configdiff import get_config_diff, Diff from vyos.configdep import set_dependents, call_dependents from vyos.configverify import verify_interface_exists @@ -132,7 +132,7 @@ def get_config(config=None): with_recursive_defaults=True) - firewall['group_resync'] = bool('group' in firewall or node_changed(conf, base + ['group'])) + firewall['group_resync'] = bool('group' in firewall or is_node_changed(conf, base + ['group'])) if firewall['group_resync']: # Update nat and policy-route as firewall groups were updated set_dependents('group_resync', conf) |