T5474: establish common file name pattern for XML conf mode commands

We will use _ as CLI level divider. The XML definition filename and also
the Python helper should match the CLI node.

Example:
set interfaces ethernet -> interfaces_ethernet.xml.in
set interfaces bond -> interfaces_bond.xml.in
set service dhcp-server -> service_dhcp-server-xml.in

1 files changed, 0 insertions, 102 deletions

diff --git a/src/conf_mode/interfaces-geneve.py b/src/conf_mode/interfaces-geneve.py
deleted file mode 100755
index f6694ddde..000000000
--- a/src/conf_mode/interfaces-geneve.py
+++ /dev/null
@@ -1,102 +0,0 @@
-#!/usr/bin/env python3
-#
-# Copyright (C) 2019-2022 VyOS maintainers and contributors
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License version 2 or later as
-# published by the Free Software Foundation.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
-from sys import exit
-from netifaces import interfaces
-
-from vyos.config import Config
-from vyos.configdict import get_interface_dict
-from vyos.configdict import is_node_changed
-from vyos.configverify import verify_address
-from vyos.configverify import verify_mtu_ipv6
-from vyos.configverify import verify_bridge_delete
-from vyos.configverify import verify_mirror_redirect
-from vyos.configverify import verify_bond_bridge_member
-from vyos.ifconfig import GeneveIf
-from vyos import ConfigError
-
-from vyos import airbag
-airbag.enable()
-
-def get_config(config=None):
-    """
-    Retrive CLI config as dictionary. Dictionary can never be empty, as at least the
-    interface name will be added or a deleted flag
-    """
-    if config:
-        conf = config
-    else:
-        conf = Config()
-    base = ['interfaces', 'geneve']
-    ifname, geneve = get_interface_dict(conf, base)
-
-    # GENEVE interfaces are picky and require recreation if certain parameters
-    # change. But a GENEVE interface should - of course - not be re-created if
-    # it's description or IP address is adjusted. Feels somehow logic doesn't it?
-    for cli_option in ['remote', 'vni', 'parameters']:
-        if is_node_changed(conf, base + [ifname, cli_option]):
-            geneve.update({'rebuild_required': {}})
-
-    return geneve
-
-def verify(geneve):
-    if 'deleted' in geneve:
-        verify_bridge_delete(geneve)
-        return None
-
-    verify_mtu_ipv6(geneve)
-    verify_address(geneve)
-    verify_bond_bridge_member(geneve)
-    verify_mirror_redirect(geneve)
-
-    if 'remote' not in geneve:
-        raise ConfigError('Remote side must be configured')
-
-    if 'vni' not in geneve:
-        raise ConfigError('VNI must be configured')
-
-    return None
-
-
-def generate(geneve):
-    return None
-
-def apply(geneve):
-    # Check if GENEVE interface already exists
-    if 'rebuild_required' in geneve or 'delete' in geneve:
-        if geneve['ifname'] in interfaces():
-            g = GeneveIf(geneve['ifname'])
-            # GENEVE is super picky and the tunnel always needs to be recreated,
-            # thus we can simply always delete it first.
-            g.remove()
-
-    if 'deleted' not in geneve:
-        # Finally create the new interface
-        g = GeneveIf(**geneve)
-        g.update(geneve)
-
-    return None
-
-
-if __name__ == '__main__':
-    try:
-        c = get_config()
-        verify(c)
-        generate(c)
-        apply(c)
-    except ConfigError as e:
-        print(e)
-        exit(1)