summaryrefslogtreecommitdiff
path: root/src/conf_mode/interfaces-pppoe.py
diff options
context:
space:
mode:
authorChristian Poessinger <christian@poessinger.com>2020-07-25 00:39:14 +0200
committerChristian Poessinger <christian@poessinger.com>2020-07-25 17:30:12 +0200
commite70a304e36fc6456e16fea81ace4a0a5fd8bd1df (patch)
tree3959df9b7a5509b84ea92fd1fb577a8e0038d004 /src/conf_mode/interfaces-pppoe.py
parent72c0ac35b4acf049de29ce1ea67af28659793098 (diff)
downloadvyos-1x-e70a304e36fc6456e16fea81ace4a0a5fd8bd1df.tar.gz
vyos-1x-e70a304e36fc6456e16fea81ace4a0a5fd8bd1df.zip
ifconfig: T2653: make ifname an optional argument to get_interface_dict()
Further reduce the boiler-plate code to determine interface tag node or not. It can be passed into get_interface_dict() if explicitly required - else it is taken from the environment.
Diffstat (limited to 'src/conf_mode/interfaces-pppoe.py')
-rwxr-xr-xsrc/conf_mode/interfaces-pppoe.py8
1 files changed, 1 insertions, 7 deletions
diff --git a/src/conf_mode/interfaces-pppoe.py b/src/conf_mode/interfaces-pppoe.py
index 6947cc1e2..b9a88a949 100755
--- a/src/conf_mode/interfaces-pppoe.py
+++ b/src/conf_mode/interfaces-pppoe.py
@@ -38,13 +38,7 @@ def get_config():
"""
conf = Config()
base = ['interfaces', 'pppoe']
-
- # determine tagNode instance
- if 'VYOS_TAGNODE_VALUE' not in os.environ:
- raise ConfigError('Interface (VYOS_TAGNODE_VALUE) not specified')
-
- ifname = os.environ['VYOS_TAGNODE_VALUE']
- pppoe = get_interface_dict(conf, base, ifname)
+ pppoe = get_interface_dict(conf, base)
# PPPoE is "special" the default MTU is 1492 - update accordingly
# as the config_level is already st in get_interface_dict() - we can use []