summaryrefslogtreecommitdiff
path: root/src/conf_mode/interfaces-vxlan.py
diff options
context:
space:
mode:
authorChristian Poessinger <christian@poessinger.com>2022-02-21 18:23:55 +0100
committerChristian Poessinger <christian@poessinger.com>2022-02-21 18:23:55 +0100
commit3a605ad020d8d20b08a72cb1284f6e590d1fd7b5 (patch)
tree74120735fc8ff725ce7be7a5b086730fc688a09f /src/conf_mode/interfaces-vxlan.py
parent25b2f2a8057260ad0d2c59823618d7c9f0fba707 (diff)
downloadvyos-1x-3a605ad020d8d20b08a72cb1284f6e590d1fd7b5.tar.gz
vyos-1x-3a605ad020d8d20b08a72cb1284f6e590d1fd7b5.zip
vxlan: T4120: code cleanup for multiple remotes
Diffstat (limited to 'src/conf_mode/interfaces-vxlan.py')
-rwxr-xr-xsrc/conf_mode/interfaces-vxlan.py38
1 files changed, 10 insertions, 28 deletions
diff --git a/src/conf_mode/interfaces-vxlan.py b/src/conf_mode/interfaces-vxlan.py
index 092f249df..85604508e 100755
--- a/src/conf_mode/interfaces-vxlan.py
+++ b/src/conf_mode/interfaces-vxlan.py
@@ -1,6 +1,6 @@
#!/usr/bin/env python3
#
-# Copyright (C) 2019-2020 VyOS maintainers and contributors
+# Copyright (C) 2019-2022 VyOS maintainers and contributors
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License version 2 or later as
@@ -34,8 +34,8 @@ airbag.enable()
def get_config(config=None):
"""
- Retrive CLI config as dictionary. Dictionary can never be empty, as at least the
- interface name will be added or a deleted flag
+ Retrive CLI config as dictionary. Dictionary can never be empty, as at least
+ the interface name will be added or a deleted flag
"""
if config:
conf = config
@@ -58,13 +58,6 @@ def get_config(config=None):
if len(vxlan['other_tunnels']) == 0:
del vxlan['other_tunnels']
- # leave first remote in dict and put the other ones (if they exists) to "other_remotes"
- remotes = vxlan.get('remote')
- if remotes:
- vxlan['remote'] = remotes[0]
- if len(remotes) > 1:
- del remotes[0]
- vxlan['other_remotes'] = remotes
return vxlan
def verify(vxlan):
@@ -77,8 +70,7 @@ def verify(vxlan):
if 'group' in vxlan:
if 'source_interface' not in vxlan:
- raise ConfigError('Multicast VXLAN requires an underlaying interface ')
-
+ raise ConfigError('Multicast VXLAN requires an underlaying interface')
verify_source_interface(vxlan)
if not any(tmp in ['group', 'remote', 'source_address'] for tmp in vxlan):
@@ -122,35 +114,26 @@ def verify(vxlan):
protocol = 'ipv6'
else:
protocol = 'ipv4'
+
if 'remote' in vxlan:
- if is_ipv6(vxlan['remote']):
- if protocol == 'ipv4':
- raise ConfigError('IPv4 and IPV6 cannot be mixed')
- protocol = 'ipv6'
- else:
- if protocol == 'ipv6':
- raise ConfigError('IPv4 and IPV6 cannot be mixed')
- protocol = 'ipv4'
- if 'other_remotes' in vxlan:
- for rem in vxlan['other_remotes']:
- if is_ipv6(rem):
+ error_msg = 'Can not mix both IPv4 and IPv6 for VXLAN underlay'
+ for remote in vxlan['remote']:
+ if is_ipv6(remote):
if protocol == 'ipv4':
- raise ConfigError('IPv4 and IPV6 cannot be mixed')
+ raise ConfigError(error_msg)
protocol = 'ipv6'
else:
if protocol == 'ipv6':
- raise ConfigError('IPv4 and IPV6 cannot be mixed')
+ raise ConfigError(error_msg)
protocol = 'ipv4'
verify_mtu_ipv6(vxlan)
verify_address(vxlan)
return None
-
def generate(vxlan):
return None
-
def apply(vxlan):
# Check if the VXLAN interface already exists
if vxlan['ifname'] in interfaces():
@@ -166,7 +149,6 @@ def apply(vxlan):
return None
-
if __name__ == '__main__':
try:
c = get_config()