summaryrefslogtreecommitdiff
path: root/src/conf_mode/interfaces-wireless.py
diff options
context:
space:
mode:
authoralainlamar <alainlamar@users.noreply.github.com>2020-04-05 18:19:23 +0200
committerGitHub <noreply@github.com>2020-04-05 18:19:23 +0200
commit7b56a45fe866f62e47c04e1dabb32b1240297ed6 (patch)
tree06d9edcbf814f7eea13360c2cf74872472c0fe1c /src/conf_mode/interfaces-wireless.py
parent9b98256339f35ff5de346b08fb1573429a0801f8 (diff)
downloadvyos-1x-7b56a45fe866f62e47c04e1dabb32b1240297ed6.tar.gz
vyos-1x-7b56a45fe866f62e47c04e1dabb32b1240297ed6.zip
wireless: T2212: bugfix for BF-ANTENNA and SOUNDING-DIMENSION flags
VHT flags deal with many variables which depend on antenna count and supported features. BF-ANTENNA-(2|3|4) and SOUNDING-DIMENSION-(2|3|4) were not dealt with correctly. IEEE 802.11ac (VHT) supports at least 1 antenna and up to 8 antennas at most. The hsotapd VHT flags may support as many but most do not. Therefore, we need to be picky here...
Diffstat (limited to 'src/conf_mode/interfaces-wireless.py')
-rwxr-xr-xsrc/conf_mode/interfaces-wireless.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/conf_mode/interfaces-wireless.py b/src/conf_mode/interfaces-wireless.py
index bf8552bc1..da8470f7e 100755
--- a/src/conf_mode/interfaces-wireless.py
+++ b/src/conf_mode/interfaces-wireless.py
@@ -584,6 +584,10 @@ def verify(wifi):
if wifi['cap_vht_beamform'] and wifi['cap_vht_antenna_cnt'] == 1:
raise ConfigError('Cannot use beam forming with just one antenna!')
+ if wifi['cap_vht_beamform'] == 'single-user-beamformer' and wifi['cap_vht_antenna_cnt'] < 3:
+ # Nasty Gotcha: see https://w1.fi/cgit/hostap/plain/hostapd/hostapd.conf lines 692-705
+ raise ConfigError('Single-user beam former requires at least 3 antennas!')
+
if wifi['sec_wep'] and (len(wifi['sec_wep_key']) == 0):
raise ConfigError('Missing WEP keys')