pppoe: T4384: replace default-route CLI option with common CLI nodes already present for DHCP

VyOS 1.4 still leverages PPPd internals on the CLI.

pppd supports three options for a default route, none, auto, force.
* none: No default route is installed on interface up
* auto: Default route is only installed if there is yet no default route
* force: overwrite any default route

There are several drawbacks in this design for VyOS and the users. If auto is
specified, this only counted for static default routes - but what about dynamic
ones? Same for force, only a static default route got replaced but dynamic ones
did not got taken into account.

The CLI is changed and we now re-use already existing nodes from the DHCP
interface configuration:
* no-default-route:
  On link up no default route is installed, same as the previous
  default-route none

* default-route-distance:
  We can now specify the distance of this route for the routing table on the
  system. This defaults to 210 as we have for DHCP interfaces. All this will be
  migrated using a CLI migration script.

1 files changed, 4 insertions, 1 deletions

diff --git a/src/conf_mode/protocols_static.py b/src/conf_mode/protocols_static.py
index 87432bc1c..58e202928 100755
--- a/src/conf_mode/protocols_static.py
+++ b/src/conf_mode/protocols_static.py
@@ -22,6 +22,7 @@ from sys import argv
 from vyos.config import Config
 from vyos.configdict import dict_merge
 from vyos.configdict import get_dhcp_interfaces
+from vyos.configdict import get_pppoe_interfaces
 from vyos.configverify import verify_common_route_maps
 from vyos.configverify import verify_vrf
 from vyos.template import render_to_string
@@ -59,7 +60,9 @@ def get_config(config=None):
 
     # T3680 - get a list of all interfaces currently configured to use DHCP
     tmp = get_dhcp_interfaces(conf, vrf)
-    if tmp: static['dhcp'] = tmp
+    if tmp: static.update({'dhcp' : tmp})
+    tmp = get_pppoe_interfaces(conf, vrf)
+    if tmp: static.update({'pppoe' : tmp})
 
     return static