summaryrefslogtreecommitdiff
path: root/src/conf_mode
diff options
context:
space:
mode:
authorChristian Poessinger <christian@poessinger.com>2021-09-07 11:41:12 +0200
committerChristian Poessinger <christian@poessinger.com>2021-09-07 11:41:12 +0200
commit7623e37c918c65418d8dfc521f976bb91f0594c0 (patch)
tree6b1d340a4b820715cb1441d07d37d494ed9fff8d /src/conf_mode
parentbd2c79ebb8abbd844f4b0568110c7bcea0d8f4f1 (diff)
downloadvyos-1x-7623e37c918c65418d8dfc521f976bb91f0594c0.tar.gz
vyos-1x-7623e37c918c65418d8dfc521f976bb91f0594c0.zip
scripts: op-mode: T3807: bugfix node.def generator
process_node() processes the XML tree in a fixed order, "node" before "tagNode" before "leafNode". If the generator created a "node.def" file, it can no longer be overwritten - else we would have some stale "node.def" files with an empty help string (T2555). Without the fixed order this would resulted in a case where we get a node and a tagNode with the same name, e.g. "show interfaces ethernet" and "show interfaces ethernet eth0" that the node implementation was not callable from the CLI, rendering this command useless (T3807). This can be fixed by forcing the "node", "tagNode", "leafNode" order by sorting the input XML file automatically (sorting from https://stackoverflow.com/a/46128043) thus adding no additional overhead to the user.
Diffstat (limited to 'src/conf_mode')
0 files changed, 0 insertions, 0 deletions