summaryrefslogtreecommitdiff
path: root/src/conf_mode
diff options
context:
space:
mode:
authorHaim Gelfenbeyn <haim@g8n.me>2024-05-30 09:30:27 -0400
committerHaim Gelfenbeyn <haim@g8n.me>2024-05-30 09:30:27 -0400
commit19d8415512dcf87dc3a87feabf128652ffc74594 (patch)
treef80c0b78a542494e41db13238032c9a3e00006a7 /src/conf_mode
parent5978273c679b053dab2b878b476f0fd350a3e243 (diff)
downloadvyos-1x-19d8415512dcf87dc3a87feabf128652ffc74594.tar.gz
vyos-1x-19d8415512dcf87dc3a87feabf128652ffc74594.zip
dns: T6422: allow multiple redundant NS records
NS is unlike CNAME or PTR, multiple NS records are perfectly valid and is a common use case: multiple redundant DNS servers is a common configuration and should be supported.
Diffstat (limited to 'src/conf_mode')
-rwxr-xr-xsrc/conf_mode/service_dns_forwarding.py15
1 files changed, 14 insertions, 1 deletions
diff --git a/src/conf_mode/service_dns_forwarding.py b/src/conf_mode/service_dns_forwarding.py
index 7e863073a..e8318a83e 100755
--- a/src/conf_mode/service_dns_forwarding.py
+++ b/src/conf_mode/service_dns_forwarding.py
@@ -102,7 +102,7 @@ def get_config(config=None):
'ttl': rdata['ttl'],
'value': address
})
- elif rtype in ['cname', 'ptr', 'ns']:
+ elif rtype in ['cname', 'ptr']:
if not 'target' in rdata:
dns['authoritative_zone_errors'].append(f'{subnode}.{node}: target is required')
continue
@@ -113,6 +113,19 @@ def get_config(config=None):
'ttl': rdata['ttl'],
'value': '{}.'.format(rdata['target'])
})
+ elif rtype == 'ns':
+ if not 'target' in rdata:
+ dns['authoritative_zone_errors'].append(f'{subnode}.{node}: at leaast one target is required')
+ continue
+
+ for target in rdata['target']:
+ zone['records'].append({
+ 'name': subnode,
+ 'type': rtype.upper(),
+ 'ttl': rdata['ttl'],
+ 'value': '{}.'.format(target)
+ })
+
elif rtype == 'mx':
if not 'server' in rdata:
dns['authoritative_zone_errors'].append(f'{subnode}.{node}: at least one server is required')