summaryrefslogtreecommitdiff
path: root/src/conf_mode
diff options
context:
space:
mode:
authorsarthurdev <965089+sarthurdev@users.noreply.github.com>2022-01-21 18:15:50 +0100
committersarthurdev <965089+sarthurdev@users.noreply.github.com>2022-01-21 22:35:30 +0100
commite31493c32d0e95ef14c627d0bf181efbb81ef062 (patch)
tree7b6c0616b3ef06fa938bc29d7463ec6fabae77ea /src/conf_mode
parent4f8f49c9945aea96e24e984de36a7ebb03916984 (diff)
downloadvyos-1x-e31493c32d0e95ef14c627d0bf181efbb81ef062.tar.gz
vyos-1x-e31493c32d0e95ef14c627d0bf181efbb81ef062.zip
firewall: T2199: Verify correct ICMP protocol for ipv4/ipv6
Diffstat (limited to 'src/conf_mode')
-rwxr-xr-xsrc/conf_mode/firewall.py6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/conf_mode/firewall.py b/src/conf_mode/firewall.py
index 82223d60b..358b938e3 100755
--- a/src/conf_mode/firewall.py
+++ b/src/conf_mode/firewall.py
@@ -184,6 +184,12 @@ def verify_rule(firewall, rule_conf, ipv6):
if duplicates:
raise ConfigError(f'Cannot match a tcp flag as set and not set')
+ if 'protocol' in rule_conf:
+ if rule_conf['protocol'] == 'icmp' and ipv6:
+ raise ConfigError(f'Cannot match IPv4 ICMP protocol on IPv6, use ipv6-icmp')
+ if rule_conf['protocol'] == 'ipv6-icmp' and not ipv6:
+ raise ConfigError(f'Cannot match IPv6 ICMP protocol on IPv4, use icmp')
+
for side in ['destination', 'source']:
if side in rule_conf:
side_conf = rule_conf[side]