syslog: T1845: syslog host no longer accepts a port

  - renamed interface xml
  - renamed syslog.py to system-syslog.py
  - moved protocol out of the facility node (bug)
  - node port created
  - migration script included

1 files changed, 13 insertions, 12 deletions

diff --git a/src/conf_mode/syslog.py b/src/conf_mode/system-syslog.py
index c4f3d2c9c..f238acc15 100755
--- a/src/conf_mode/syslog.py
+++ b/src/conf_mode/system-syslog.py
@@ -53,9 +53,9 @@ $outchannel {{file}},{{files[file]['log-file']}},{{files[file]['max-size']}},{{f
 ## remote logging
 {% for host in hosts %}
 {% if hosts[host]['proto'] == 'tcp' %}
-{{hosts[host]['selectors']}} @@{{host}}
+{{hosts[host]['selectors']}} @@{{host}}:{{hosts[host]['port']}}
 {% else %}
-{{hosts[host]['selectors']}} @{{host}}
+{{hosts[host]['selectors']}} @{{host}}:{{hosts[host]['port']}}
 {% endif %}
 {% endfor %}
 {% endif %}
@@ -177,19 +177,22 @@ def get_config():
 
     # set system syslog host
     if c.exists('host'):
-        proto = 'udp'
-        rhosts = c.list_nodes('host')
+        rhosts = c.list_nodes(['host'])
         for rhost in rhosts:
-            for fac in c.list_nodes('host ' + rhost + ' facility'):
-                if c.exists('host ' + rhost + ' facility ' + fac + ' protocol'):
-                    proto = c.return_value(
-                        'host ' + rhost + ' facility ' + fac + ' protocol')
-
+            if c.exists('host ' + rhost + ' port'):
+                port = c.return_value(['host', rhost, 'port'])
+            else:
+                port = '514'
+            if c.exists('host ' + rhost + ' protocol'):
+                proto = c.return_value(['host', rhost, 'protocol'])            
+            else:
+                proto = 'udp'
             config_data['hosts'].update(
                 {
                     rhost: {
                         'selectors': generate_selectors(c, 'host ' + rhost + ' facility'),
-                        'proto': proto
+                        'proto': proto,
+                        'port' : port
                     }
                 }
             )
@@ -289,7 +292,6 @@ def verify(c):
                 for s in c[conf][item]['selectors'].split(";"):
                     f = re.sub("\..*$", "", s)
                     if f not in fac:
-                        print (c[conf])
                         raise ConfigError(
                             'Invalid facility ' + s + ' set in ' + conf + ' ' + item)
                     l = re.sub("^.+\.", "", s)
@@ -297,7 +299,6 @@ def verify(c):
                         raise ConfigError(
                             'Invalid logging level ' + s + ' set in ' + conf + ' ' + item)
 
-
 def apply(c):
     if not c and os.path.exists('/var/run/rsyslogd.pid'):
         os.system("sudo systemctl stop syslog.socket")