diff options
| author | Viacheslav Hletenko <v.gletenko@vyos.io> | 2024-01-23 10:53:08 +0000 |
|---|---|---|
| committer | Mergify <37929162+mergify[bot]@users.noreply.github.com> | 2024-02-01 16:03:36 +0000 |
| commit | 050b2eb42b0356ff446fe6fed1be4bad1f754f77 (patch) | |
| tree | 6b901d43fdc532f2d76633fb1b63e55c112d4e60 /src/conf_mode | |
| parent | dbbc4962b449b8bb6bef26ae56b9a09d5107588c (diff) | |
| download | vyos-1x-050b2eb42b0356ff446fe6fed1be4bad1f754f77.tar.gz vyos-1x-050b2eb42b0356ff446fe6fed1be4bad1f754f77.zip | |
T5974: Fix QoS shape bandwidth and ceil calculation for default
The default `bandwidth` and `ceiling` should calculate values
based on <tag> bandwidth but currently it gets the value from
qos.base `/sys/class/net/{self._interface}/speed`
```
set qos policy shaper SHAPER bandwidth '20mbit'
set qos policy shaper SHAPER default bandwidth '95%'
set qos policy shaper SHAPER default ceiling '100%'
```
It causes wrong calculations for class `default` i.e
950Mbit for bandwidth (expected 95% of bandwidth, 19Mbit)
1Gbit for ceil (expected 100% of bandwidth, 20Mbit)
Gets incorrect values
```
r4# tc class show dev eth1
class htb 1:1 root rate 20Mbit ceil 20Mbit burst 1600b cburst 1600b
class htb 1:a parent 1:1 leaf 8053: prio 0 rate 200Kbit ceil 200Kbit burst 1Mb cburst 1600b
class htb 1:b parent 1:1 leaf 8054: prio 7 rate 950Mbit ceil 1Gbit burst 15200b cburst 1375b
```
Fix this
(cherry picked from commit 6ddfe6328e1cbdde1b70763b39e3a87f8374755a)
Diffstat (limited to 'src/conf_mode')
0 files changed, 0 insertions, 0 deletions