migration: T6007: convert all migration scripts to load as module

1 files changed, 40 insertions, 58 deletions

diff --git a/src/migration-scripts/dhcp-server/7-to-8 b/src/migration-scripts/dhcp-server/7-to-8
index ccf385a30..7fcb62e86 100755..100644
--- a/src/migration-scripts/dhcp-server/7-to-8
+++ b/src/migration-scripts/dhcp-server/7-to-8
@@ -1,18 +1,17 @@
-#!/usr/bin/env python3
+# Copyright 2023-2024 VyOS maintainers and contributors <maintainers@vyos.io>
 #
-# Copyright (C) 2023 VyOS maintainers and contributors
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 2.1 of the License, or (at your option) any later version.
 #
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License version 2 or later as
-# published by the Free Software Foundation.
-#
-# This program is distributed in the hope that it will be useful,
+# This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+# You should have received a copy of the GNU Lesser General Public License
+# along with this library.  If not, see <http://www.gnu.org/licenses/>.
 
 # T3316: Migrate to Kea
 #        - global-parameters will not function
@@ -23,65 +22,48 @@
 #        - ping-check no longer supported
 #        - failover is default enabled on all subnets that exist on failover servers
 
-import sys
 from vyos.configtree import ConfigTree
 
-if (len(sys.argv) < 2):
-    print("Must specify file name!")
-    sys.exit(1)
-
-file_name = sys.argv[1]
-
-with open(file_name, 'r') as f:
-    config_file = f.read()
-
 base = ['service', 'dhcp-server']
-config = ConfigTree(config_file)
-
-if not config.exists(base):
-    # Nothing to do
-    sys.exit(0)
 
-if config.exists(base + ['host-decl-name']):
-    config.delete(base + ['host-decl-name'])
+def migrate(config: ConfigTree) -> None:
+    if not config.exists(base):
+        # Nothing to do
+        return
 
-if config.exists(base + ['global-parameters']):
-    config.delete(base + ['global-parameters'])
+    if config.exists(base + ['host-decl-name']):
+        config.delete(base + ['host-decl-name'])
 
-if config.exists(base + ['shared-network-name']):
-    for network in config.list_nodes(base + ['shared-network-name']):
-        base_network = base + ['shared-network-name', network]
+    if config.exists(base + ['global-parameters']):
+        config.delete(base + ['global-parameters'])
 
-        if config.exists(base_network + ['ping-check']):
-            config.delete(base_network + ['ping-check'])
+    if config.exists(base + ['shared-network-name']):
+        for network in config.list_nodes(base + ['shared-network-name']):
+            base_network = base + ['shared-network-name', network]
 
-        if config.exists(base_network + ['shared-network-parameters']):
-            config.delete(base_network +['shared-network-parameters'])
+            if config.exists(base_network + ['ping-check']):
+                config.delete(base_network + ['ping-check'])
 
-        if not config.exists(base_network + ['subnet']):
-            continue
+            if config.exists(base_network + ['shared-network-parameters']):
+                config.delete(base_network +['shared-network-parameters'])
 
-        # Run this for every specified 'subnet'
-        for subnet in config.list_nodes(base_network + ['subnet']):
-            base_subnet = base_network + ['subnet', subnet]
+            if not config.exists(base_network + ['subnet']):
+                continue
 
-            if config.exists(base_subnet + ['enable-failover']):
-                config.delete(base_subnet + ['enable-failover'])
+            # Run this for every specified 'subnet'
+            for subnet in config.list_nodes(base_network + ['subnet']):
+                base_subnet = base_network + ['subnet', subnet]
 
-            if config.exists(base_subnet + ['ping-check']):
-                config.delete(base_subnet + ['ping-check'])
+                if config.exists(base_subnet + ['enable-failover']):
+                    config.delete(base_subnet + ['enable-failover'])
 
-            if config.exists(base_subnet + ['subnet-parameters']):
-                config.delete(base_subnet + ['subnet-parameters'])
+                if config.exists(base_subnet + ['ping-check']):
+                    config.delete(base_subnet + ['ping-check'])
 
-            if config.exists(base_subnet + ['static-mapping']):
-                for mapping in config.list_nodes(base_subnet + ['static-mapping']):
-                    if config.exists(base_subnet + ['static-mapping', mapping, 'static-mapping-parameters']):
-                        config.delete(base_subnet + ['static-mapping', mapping, 'static-mapping-parameters'])
+                if config.exists(base_subnet + ['subnet-parameters']):
+                    config.delete(base_subnet + ['subnet-parameters'])
 
-try:
-    with open(file_name, 'w') as f:
-        f.write(config.to_string())
-except OSError as e:
-    print("Failed to save the modified config: {}".format(e))
-    exit(1)
+                if config.exists(base_subnet + ['static-mapping']):
+                    for mapping in config.list_nodes(base_subnet + ['static-mapping']):
+                        if config.exists(base_subnet + ['static-mapping', mapping, 'static-mapping-parameters']):
+                            config.delete(base_subnet + ['static-mapping', mapping, 'static-mapping-parameters'])