Merge pull request #3692 from jestabro/revise-migration

T6007: revise migration system

1 files changed, 24 insertions, 42 deletions

diff --git a/src/migration-scripts/pppoe-server/9-to-10 b/src/migration-scripts/pppoe-server/9-to-10
index e0c782f04..d3475e8ff 100755..100644
--- a/src/migration-scripts/pppoe-server/9-to-10
+++ b/src/migration-scripts/pppoe-server/9-to-10
@@ -1,56 +1,38 @@
-#!/usr/bin/env python3
+# Copyright 2024 VyOS maintainers and contributors <maintainers@vyos.io>
 #
-# Copyright (C) 2024 VyOS maintainers and contributors
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 2.1 of the License, or (at your option) any later version.
 #
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License version 2 or later as
-# published by the Free Software Foundation.
-#
-# This program is distributed in the hope that it will be useful,
+# This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+# You should have received a copy of the GNU Lesser General Public License
+# along with this library.  If not, see <http://www.gnu.org/licenses/>.
 
 # Migration of pado-delay options
 
-from sys import argv
-from sys import exit
 from vyos.configtree import ConfigTree
 
-if len(argv) < 2:
-    print("Must specify file name!")
-    exit(1)
-
-file_name = argv[1]
-
-with open(file_name, 'r') as f:
-    config_file = f.read()
-
-config = ConfigTree(config_file)
 base = ['service', 'pppoe-server', 'pado-delay']
-if not config.exists(base):
-    exit(0)
 
-pado_delay = {}
-for delay in config.list_nodes(base):
-    sessions = config.return_value(base + [delay, 'sessions'])
-    pado_delay[delay] = sessions
+def migrate(config: ConfigTree) -> None:
+    if not config.exists(base):
+        return
 
-# need to define delay for latest sessions
-sorted_delays = dict(sorted(pado_delay.items(), key=lambda k_v: int(k_v[1])))
-last_delay = list(sorted_delays)[-1]
+    pado_delay = {}
+    for delay in config.list_nodes(base):
+        sessions = config.return_value(base + [delay, 'sessions'])
+        pado_delay[delay] = sessions
 
-# Rename last delay -> disable
-tmp = base + [last_delay]
-if config.exists(tmp):
-    config.rename(tmp, 'disable')
+    # need to define delay for latest sessions
+    sorted_delays = dict(sorted(pado_delay.items(), key=lambda k_v: int(k_v[1])))
+    last_delay = list(sorted_delays)[-1]
 
-try:
-    with open(file_name, 'w') as f:
-        f.write(config.to_string())
-except OSError as e:
-    print("Failed to save the modified config: {}".format(e))
-    exit(1)
+    # Rename last delay -> disable
+    tmp = base + [last_delay]
+    if config.exists(tmp):
+        config.rename(tmp, 'disable')