Merge pull request #4613 from c-po/add-pylint

T7648: Set up a linter check to check complete files for syntax errors and missing imports

3 files changed, 4 insertions, 9 deletions

diff --git a/src/op_mode/connect_disconnect.py b/src/op_mode/connect_disconnect.py
index 9035ce072..117e65713 100755
--- a/src/op_mode/connect_disconnect.py
+++ b/src/op_mode/connect_disconnect.py
@@ -18,6 +18,7 @@ import os
 import argparse
 
 from psutil import process_iter
+from time import sleep
 
 from vyos.configquery import ConfigTreeQuery
 from vyos.utils.process import call
@@ -68,7 +69,7 @@ def connect(interface):
             if ( count % 60 == 0 ):
                 print(f'Commit still in progress after {count}s - waiting')
             count += 1
-            time.sleep(1)
+            sleep(1)
         call('/usr/libexec/vyos/conf_mode/qos.py')
 
 def disconnect(interface):
diff --git a/src/op_mode/pki.py b/src/op_mode/pki.py
index 2ee57a458..0f144443b 100755
--- a/src/op_mode/pki.py
+++ b/src/op_mode/pki.py
@@ -417,7 +417,7 @@ def parse_san_string(san_string):
             output.append(ipaddress.IPv6Address(value))
         elif tag == 'dns' or tag == 'rfc822':
             output.append(value)
-    return
+    return output
 
 
 def generate_certificate_request(
diff --git a/src/op_mode/storage.py b/src/op_mode/storage.py
index 7e869e9d9..0f3fabe32 100755
--- a/src/op_mode/storage.py
+++ b/src/op_mode/storage.py
@@ -13,10 +13,8 @@
 #
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
 
 import sys
-
 import vyos.opmode
 
 from jinja2 import Template
@@ -28,9 +26,6 @@ Used:       {{used}} ({{use_percentage}}%)
 Available:  {{avail}} ({{avail_percentage}}%)
 """
 
-def _get_formatted_output():
-    return _get_system_storage()
-
 def show(raw: bool):
     from vyos.utils.disk import get_persistent_storage_stats
 
@@ -49,7 +44,7 @@ def show(raw: bool):
             tmpl = Template(output_tmpl)
             return tmpl.render(data).strip()
 
-    return output
+    return None
 
 if __name__ == '__main__':
     try:
@@ -59,4 +54,3 @@ if __name__ == '__main__':
     except (ValueError, vyos.opmode.Error) as e:
         print(e)
         sys.exit(1)
-