summaryrefslogtreecommitdiff
path: root/src/tests/test_op_mode.py
diff options
context:
space:
mode:
authorJohn Estabrook <jestabro@vyos.io>2022-10-20 13:21:37 -0500
committerGitHub <noreply@github.com>2022-10-20 13:21:37 -0500
commit66fb698a106ed56677fdaaef1a934d0ea7b96561 (patch)
tree161cfb75244c7526017202ae95840399698df7c8 /src/tests/test_op_mode.py
parent0ac50cd67c14d011b600fa2362b7f6b405299b30 (diff)
parent36c475ec3524739f9ae49420e60a57a5266fa575 (diff)
downloadvyos-1x-66fb698a106ed56677fdaaef1a934d0ea7b96561.tar.gz
vyos-1x-66fb698a106ed56677fdaaef1a934d0ea7b96561.zip
Merge pull request #1607 from dmbaturin/op-mode-field-normalization
T4765: normalize dict fields in op mode ouputs
Diffstat (limited to 'src/tests/test_op_mode.py')
-rw-r--r--src/tests/test_op_mode.py44
1 files changed, 44 insertions, 0 deletions
diff --git a/src/tests/test_op_mode.py b/src/tests/test_op_mode.py
new file mode 100644
index 000000000..4786357c5
--- /dev/null
+++ b/src/tests/test_op_mode.py
@@ -0,0 +1,44 @@
+#!/usr/bin/env python3
+#
+# Copyright (C) 2022 VyOS maintainers and contributors
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 2 or later as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+from unittest import TestCase
+
+import vyos.opmode
+
+class TestVyOSOpMode(TestCase):
+ def test_field_name_normalization(self):
+ from vyos.opmode import _normalize_field_name
+
+ self.assertEqual(_normalize_field_name(" foo bar "), "foo_bar")
+ self.assertEqual(_normalize_field_name("foo-bar"), "foo_bar")
+ self.assertEqual(_normalize_field_name("foo (bar) baz"), "foo_bar_baz")
+ self.assertEqual(_normalize_field_name("load%"), "load_percentage")
+
+ def test_dict_fields_normalization_non_unique(self):
+ from vyos.opmode import _normalize_field_names
+
+ # Space and dot are both replaced by an underscore,
+ # so dicts like this cannor be normalized uniquely
+ data = {"foo bar": True, "foo.bar": False}
+
+ with self.assertRaises(vyos.opmode.InternalError):
+ _normalize_field_names(data)
+
+ def test_dict_fields_normalization(self):
+ from vyos.opmode import _normalize_field_names
+
+ data = {"foo bar": True, "bar-baz": False}
+ self.assertEqual(_normalize_field_names(data), {"foo_bar": True, "bar_baz": False})