diff options
author | sarthurdev <965089+sarthurdev@users.noreply.github.com> | 2022-01-09 23:36:31 +0100 |
---|---|---|
committer | sarthurdev <965089+sarthurdev@users.noreply.github.com> | 2022-01-10 19:02:32 +0100 |
commit | 67ab8154685638b373b139aaf9a936cbcb83a84f (patch) | |
tree | 485a0fc90b2220b42474bc5a447c8d77cd03e2bb /src | |
parent | deb9bfa02863ea28104f36558ed4e90caba792e3 (diff) | |
download | vyos-1x-67ab8154685638b373b139aaf9a936cbcb83a84f.tar.gz vyos-1x-67ab8154685638b373b139aaf9a936cbcb83a84f.zip |
firewall: 4149: Fix verify steps being bypassed when base node is removed
Diffstat (limited to 'src')
-rwxr-xr-x | src/conf_mode/firewall.py | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/src/conf_mode/firewall.py b/src/conf_mode/firewall.py index 75382034f..0b4c0854f 100755 --- a/src/conf_mode/firewall.py +++ b/src/conf_mode/firewall.py @@ -104,9 +104,6 @@ def get_config(config=None): conf = Config() base = ['firewall'] - if not conf.exists(base): - return {} - firewall = conf.get_config_dict(base, key_mangling=('-', '_'), get_first_key=True, no_tag_node_value_mangle=True) @@ -169,10 +166,6 @@ def verify_rule(firewall, rule_conf, ipv6): raise ConfigError('Protocol must be tcp, udp, or tcp_udp when specifying a port or port-group') def verify(firewall): - # bail out early - looks like removal from running config - if not firewall: - return None - if 'config_trap' in firewall and firewall['config_trap'] == 'enable': if not firewall['trap_targets']: raise ConfigError(f'Firewall config-trap enabled but "service snmp trap-target" is not defined') |