diff options
| author | Christian Breunig <christian@breunig.cc> | 2026-03-18 09:13:25 +0100 |
|---|---|---|
| committer | Christian Breunig <christian@breunig.cc> | 2026-03-18 09:13:25 +0100 |
| commit | 6c3280e47a5613f09f64a62991262e53c0f5fc25 (patch) | |
| tree | b1cb9cbfad7ff502389ddd2bce71827de04632c8 /src | |
| parent | e58b538fa3d37a9843507d4cd670560a03e336f1 (diff) | |
| download | vyos-1x-6c3280e47a5613f09f64a62991262e53c0f5fc25.tar.gz vyos-1x-6c3280e47a5613f09f64a62991262e53c0f5fc25.zip | |
op-mode: T8400: remove calls to tshark binary for PCAP files
The tshark binary might not be installed in every image, thus this command is
not only gambling if it will work or not, it will also bloat the image if
installed.
PCAP files should be properly revisited on a workstation and not on a NOS
(Network Operating System).
Diffstat (limited to 'src')
| -rwxr-xr-x | src/op_mode/file.py | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/op_mode/file.py b/src/op_mode/file.py index a0efdb5cb..8420c5355 100755 --- a/src/op_mode/file.py +++ b/src/op_mode/file.py @@ -133,9 +133,6 @@ def print_file_data(path: str) -> None: with open(path, 'r') as f: for line in f: print(line, end='') - # tcpdump files go to TShark. - elif 'pcap' in file_type or os.path.splitext(path)[1] == '.pcap': - print(cmd(['sudo', 'tshark', '-r', path])) # All other binaries get hexdumped. else: print(cmd(['hexdump', '-C', path])) |