Merge pull request #4919 from alexandr-san4ez/T7730-current

interfaces: T7730: Add interrupt coalescing settings for Ethernet interfaces

1 files changed, 22 insertions, 0 deletions

diff --git a/src/conf_mode/interfaces_ethernet.py b/src/conf_mode/interfaces_ethernet.py
index 554f0fa41..2a65855a4 100755
--- a/src/conf_mode/interfaces_ethernet.py
+++ b/src/conf_mode/interfaces_ethernet.py
@@ -37,6 +37,7 @@ from vyos.configverify import verify_vrf
 from vyos.configverify import verify_bond_bridge_member
 from vyos.configverify import verify_eapol
 from vyos.ethtool import Ethtool
+from vyos.netlink import coalesce
 from vyos.frrender import FRRender
 from vyos.frrender import get_frrender_dict
 from vyos.ifconfig import EthernetIf
@@ -256,6 +257,26 @@ def verify_ring_buffer(ethernet: dict, ethtool: Ethtool):
                               f'size of "{max_tx}" bytes!')
 
 
+def verify_coalesce(ethernet: dict, ethtool: Ethtool):
+    """
+    Verify coalesce settings
+    :param ethernet: dictionary which is received from get_interface_dict
+    :type ethernet: dict
+    :param ethtool: Ethernet object
+    :type ethtool: Ethtool
+    """
+    if 'interrupt_coalescing' in ethernet:
+        if not ethtool.check_coalesce():
+            raise ConfigError('Driver does not fully support coalesce configuration!')
+
+        for param in coalesce.get_all_params():
+            if param in ethernet['interrupt_coalescing']:
+                if not ethtool.check_coalesce(param):
+                    param_name = param.replace('_', '-')
+                    msg = f'Driver does not support "{param_name}" coalesce setting!'
+                    raise ConfigError(msg)
+
+
 def verify_offload(ethernet: dict, ethtool: Ethtool):
     """
      Verify offloading capabilities
@@ -398,6 +419,7 @@ def verify(ethernet):
     verify_ring_buffer(ethernet, ethtool)
     verify_offload(ethernet, ethtool)
     verify_mac_change(ethernet, ethtool)
+    verify_coalesce(ethernet, ethtool)
 
     if 'is_bond_member' in ethernet:
         verify_bond_member(ethernet, ethtool)