snmp: T3996: fix invalid IPv6 localhost handling when using listen-address

We need to use a temporary variable when validating the tuple if address
is used. If not the else branch will always add the tuple to the list of
addresses used for listen-address.

1 files changed, 12 insertions, 7 deletions

diff --git a/src/conf_mode/snmp.py b/src/conf_mode/snmp.py
index 2a420b193..e1852f2ce 100755
--- a/src/conf_mode/snmp.py
+++ b/src/conf_mode/snmp.py
@@ -20,13 +20,17 @@ from sys import exit
 
 from vyos.config import Config
 from vyos.configverify import verify_vrf
-from vyos.snmpv3_hashgen import plaintext_to_md5, plaintext_to_sha1, random
+from vyos.snmpv3_hashgen import plaintext_to_md5
+from vyos.snmpv3_hashgen import plaintext_to_sha1
+from vyos.snmpv3_hashgen import random
 from vyos.template import render
 from vyos.template import is_ipv4
-from vyos.util import call, chmod_755
+from vyos.util import call
+from vyos.util import chmod_755
 from vyos.validate import is_addr_assigned
 from vyos.version import get_version_data
-from vyos import ConfigError, airbag
+from vyos import ConfigError
+from vyos import airbag
 airbag.enable()
 
 config_file_client  = r'/etc/snmp/snmp.conf'
@@ -410,19 +414,20 @@ def verify(snmp):
         port = listen[1]
         protocol = snmp['protocol']
 
+        tmp = None
         if is_ipv4(addr):
             # example: udp:127.0.0.1:161
-            listen = f'{protocol}:{addr}:{port}'
+            tmp = f'{protocol}:{addr}:{port}'
         elif snmp['ipv6_enabled']:
             # example: udp6:[::1]:161
-            listen = f'{protocol}6:[{addr}]:{port}'
+            tmp = f'{protocol}6:[{addr}]:{port}'
 
         # We only wan't to configure addresses that exist on the system.
         # Hint the user if they don't exist
         if is_addr_assigned(addr):
-            snmp['listen_on'].append(listen)
+            if tmp: snmp['listen_on'].append(tmp)
         else:
-            print('WARNING: SNMP listen address {0} not configured!'.format(addr))
+            print(f'WARNING: SNMP listen address {addr} not configured!')
 
     verify_vrf(snmp)