summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorChristian Poessinger <christian@poessinger.com>2021-12-04 14:51:19 +0100
committerChristian Poessinger <christian@poessinger.com>2021-12-04 14:51:19 +0100
commitf89d51293fb276fe64367b3019004c3e53a79821 (patch)
tree8fe7124471b6ce1836ef9ba453eca0502126fa5a /src
parent84b29c7c71af6663ef26dc40475cf4b0e5b179a6 (diff)
downloadvyos-1x-f89d51293fb276fe64367b3019004c3e53a79821.tar.gz
vyos-1x-f89d51293fb276fe64367b3019004c3e53a79821.zip
bgp: T4042: bugfix route-distinguisher value range
Diffstat (limited to 'src')
-rwxr-xr-xsrc/validators/bgp-rd-rt22
1 files changed, 15 insertions, 7 deletions
diff --git a/src/validators/bgp-rd-rt b/src/validators/bgp-rd-rt
index 24b0043f9..b2b69c9be 100755
--- a/src/validators/bgp-rd-rt
+++ b/src/validators/bgp-rd-rt
@@ -19,29 +19,37 @@ from vyos.template import is_ipv4
parser = ArgumentParser()
group = parser.add_mutually_exclusive_group()
+group.add_argument('--route-distinguisher', action='store', help='Validate BGP route distinguisher')
group.add_argument('--route-target', action='store', help='Validate one BGP route-target')
group.add_argument('--route-target-multi', action='store', help='Validate multiple, whitespace separated BGP route-targets')
args = parser.parse_args()
-def is_valid_rt(rt):
- # every route target needs to have a colon and must consists of two parts
+def is_valid(rt):
+ """ Verify BGP RD/RT - both can be verified using the same logic """
+ # every RD/RT (route distinguisher/route target) needs to have a colon and
+ # must consists of two parts
value = rt.split(':')
if len(value) != 2:
return False
- # A route target must either be only numbers, or the first part must be an
- # IPv4 address
+
+ # An RD/RT must either be only numbers, or the first part must be an IPv4
+ # address
if (is_ipv4(value[0]) or value[0].isdigit()) and value[1].isdigit():
return True
return False
if __name__ == '__main__':
- if args.route_target:
- if not is_valid_rt(args.route_target):
+ if args.route_distinguisher:
+ if not is_valid(args.route_distinguisher):
+ exit(1)
+
+ elif args.route_target:
+ if not is_valid(args.route_target):
exit(1)
elif args.route_target_multi:
for rt in args.route_target_multi.split(' '):
- if not is_valid_rt(rt):
+ if not is_valid(rt):
exit(1)
else: