summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorChristian Poessinger <christian@poessinger.com>2022-09-14 16:34:20 +0200
committerGitHub <noreply@github.com>2022-09-14 16:34:20 +0200
commitf379df09d8392bda6b081dc8668b435d2d806478 (patch)
tree77cc738572f2cab6843f1b1b282c5c2966cefc15 /src
parent2309f4075831778e9e23a031eac10f17f40f79bd (diff)
parentf7bab4058d8677079db32bdc2e6c452267b98694 (diff)
downloadvyos-1x-f379df09d8392bda6b081dc8668b435d2d806478.tar.gz
vyos-1x-f379df09d8392bda6b081dc8668b435d2d806478.zip
Merge pull request #1530 from sever-sever/T4679
openvpn: T4679: Fix incorrect verify local and remote address
Diffstat (limited to 'src')
-rwxr-xr-xsrc/conf_mode/interfaces-openvpn.py3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/conf_mode/interfaces-openvpn.py b/src/conf_mode/interfaces-openvpn.py
index ef745d737..8155f36c2 100755
--- a/src/conf_mode/interfaces-openvpn.py
+++ b/src/conf_mode/interfaces-openvpn.py
@@ -55,6 +55,7 @@ from vyos.util import chown
from vyos.util import cmd
from vyos.util import dict_search
from vyos.util import dict_search_args
+from vyos.util import is_list_equal
from vyos.util import makedir
from vyos.util import read_file
from vyos.util import write_file
@@ -274,7 +275,7 @@ def verify(openvpn):
elif v6remAddr and not v6loAddr:
raise ConfigError('IPv6 "remote-address" requires IPv6 "local-address"')
- if (v4loAddr == v4remAddr) or (v6remAddr == v4remAddr):
+ if is_list_equal(v4loAddr, v4remAddr) or is_list_equal(v6loAddr, v6remAddr):
raise ConfigError('"local-address" and "remote-address" cannot be the same')
if dict_search('local_host', openvpn) in dict_search('local_address', openvpn):