diff options
| author | Daniil Baturin <daniil@vyos.io> | 2026-08-13 15:29:48 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2026-08-13 15:29:48 +0100 |
| commit | 77f89fe710db1f934c9f040f3de4e7fee7f65847 (patch) | |
| tree | 070f550b9dd6cb1933aac85a7f6fdd9083a72477 /src | |
| parent | 738eb3461ff70234e05f08bbbe1568d14ae4132e (diff) | |
| parent | 29a7078648abace564621a36a87eaad46528684d (diff) | |
| download | vyos-1x-77f89fe710db1f934c9f040f3de4e7fee7f65847.tar.gz vyos-1x-77f89fe710db1f934c9f040f3de4e7fee7f65847.zip | |
Merge pull request #5383 from ruben-herold/T9177-are-same-ip-family-fix
utils: T9177: fix _are_same_ip() using wrong address family
Diffstat (limited to 'src')
| -rw-r--r-- | src/tests/test_utils_network.py | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/src/tests/test_utils_network.py b/src/tests/test_utils_network.py index 6d9a358c1..5c2f708ff 100644 --- a/src/tests/test_utils_network.py +++ b/src/tests/test_utils_network.py @@ -35,7 +35,7 @@ class TestVyOSUtilsNetwork(TestCase): self.assertFalse(vyos.utils.network.is_ipv6_link_local('::1')) self.assertFalse(vyos.utils.network.is_ipv6_link_local('::1%lo')) - def test_is_ipv6_link_local(self): + def test_is_loopback_addr(self): self.assertTrue(vyos.utils.network.is_loopback_addr('127.0.0.1')) self.assertTrue(vyos.utils.network.is_loopback_addr('127.0.1.1')) self.assertTrue(vyos.utils.network.is_loopback_addr('127.1.1.1')) @@ -44,6 +44,15 @@ class TestVyOSUtilsNetwork(TestCase): self.assertFalse(vyos.utils.network.is_loopback_addr('::2')) self.assertFalse(vyos.utils.network.is_loopback_addr('192.0.2.1')) + def test_are_same_ip(self): + self.assertTrue(vyos.utils.network._are_same_ip('192.0.2.1', '192.0.2.1')) + self.assertFalse(vyos.utils.network._are_same_ip('192.0.2.1', '192.0.2.2')) + self.assertTrue(vyos.utils.network._are_same_ip('::1', '::1')) + self.assertFalse(vyos.utils.network._are_same_ip('::1', '::2')) + # mixed address families must never compare equal, and must not raise + self.assertFalse(vyos.utils.network._are_same_ip('192.0.2.1', '::1')) + self.assertFalse(vyos.utils.network._are_same_ip('::1', '192.0.2.1')) + def test_check_port_availability(self): self.assertTrue(vyos.utils.network.check_port_availability('::1', 8080)) self.assertTrue(vyos.utils.network.check_port_availability('127.0.0.1', 8080)) |