Merge pull request #5525 from alexk37/policy-prefix-list-dup-set

policy: T9379: prefix-list duplicate check in linear time

1 files changed, 4 insertions, 3 deletions

diff --git a/src/conf_mode/policy.py b/src/conf_mode/policy.py
index 9f10178af..7cc2488b5 100755
--- a/src/conf_mode/policy.py
+++ b/src/conf_mode/policy.py
@@ -131,7 +131,7 @@ def verify(config_dict):
 
             # human readable instance name (hyphen instead of underscore)
             policy_hr = policy_type.replace('_', '-')
-            entries = []
+            entries = set()
             for rule, rule_config in instance_config['rule'].items():
                 mandatory_error = f'must be specified for "{policy_hr} {instance} rule {rule}"!'
                 if 'action' not in rule_config:
@@ -185,10 +185,11 @@ def verify(config_dict):
                             f'"le" ({le})'
                         )
 
-                    if rule_config in entries:
+                    key = tuple(sorted(rule_config.items()))
+                    if key in entries:
                         raise ConfigError(
                             f'Rule "{rule}" contains a duplicate prefix definition!')
-                    entries.append(rule_config)
+                    entries.add(key)
 
     # route-maps tend to be a bit more complex so they get their own verify() section
     if 'route_map' in policy: