diff options
27 files changed, 28 insertions, 38 deletions
diff --git a/interface-definitions/include/generic-description.xml.i b/interface-definitions/include/generic-description.xml.i index b54897be4..b030c2495 100644 --- a/interface-definitions/include/generic-description.xml.i +++ b/interface-definitions/include/generic-description.xml.i @@ -7,8 +7,9 @@        <description>Description</description>      </valueHelp>      <constraint> -      <regex>[a-zA-Z0-9_\-\s]+</regex> +      <regex>[[:ascii:]]{1,256}</regex>      </constraint> +    <constraintErrorMessage>Description too long (limit 256 characters)</constraintErrorMessage>    </properties>  </leafNode>  <!-- include end --> diff --git a/interface-definitions/include/interface/description.xml.i b/interface-definitions/include/interface/description.xml.i deleted file mode 100644 index de01d22ca..000000000 --- a/interface-definitions/include/interface/description.xml.i +++ /dev/null @@ -1,11 +0,0 @@ -<!-- include start from interface/description.xml.i --> -<leafNode name="description"> -  <properties> -    <help>Interface specific description</help> -    <constraint> -      <regex>.{1,256}</regex> -    </constraint> -    <constraintErrorMessage>Description too long (limit 256 characters)</constraintErrorMessage> -  </properties> -</leafNode> -<!-- include end --> diff --git a/interface-definitions/include/interface/vif-s.xml.i b/interface-definitions/include/interface/vif-s.xml.i index 6d50d7238..fdd62b63d 100644 --- a/interface-definitions/include/interface/vif-s.xml.i +++ b/interface-definitions/include/interface/vif-s.xml.i @@ -12,8 +12,8 @@      <constraintErrorMessage>VLAN ID must be between 0 and 4094</constraintErrorMessage>    </properties>    <children> +    #include <include/generic-description.xml.i>      #include <include/interface/address-ipv4-ipv6-dhcp.xml.i> -    #include <include/interface/description.xml.i>      #include <include/interface/dhcp-options.xml.i>      #include <include/interface/dhcpv6-options.xml.i>      #include <include/interface/disable-link-detect.xml.i> @@ -53,8 +53,8 @@          <constraintErrorMessage>VLAN ID must be between 0 and 4094</constraintErrorMessage>        </properties>        <children> +        #include <include/generic-description.xml.i>          #include <include/interface/address-ipv4-ipv6-dhcp.xml.i> -        #include <include/interface/description.xml.i>          #include <include/interface/dhcp-options.xml.i>          #include <include/interface/dhcpv6-options.xml.i>          #include <include/interface/disable-link-detect.xml.i> diff --git a/interface-definitions/include/interface/vif.xml.i b/interface-definitions/include/interface/vif.xml.i index 3f8f113ea..ec3921bf6 100644 --- a/interface-definitions/include/interface/vif.xml.i +++ b/interface-definitions/include/interface/vif.xml.i @@ -12,8 +12,8 @@      <constraintErrorMessage>VLAN ID must be between 0 and 4094</constraintErrorMessage>    </properties>    <children> +    #include <include/generic-description.xml.i>      #include <include/interface/address-ipv4-ipv6-dhcp.xml.i> -    #include <include/interface/description.xml.i>      #include <include/interface/dhcp-options.xml.i>      #include <include/interface/dhcpv6-options.xml.i>      #include <include/interface/disable-link-detect.xml.i> diff --git a/interface-definitions/interfaces-bonding.xml.in b/interface-definitions/interfaces-bonding.xml.in index a8a558348..6e8c5283a 100644 --- a/interface-definitions/interfaces-bonding.xml.in +++ b/interface-definitions/interfaces-bonding.xml.in @@ -49,7 +49,7 @@                </leafNode>              </children>            </node> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/dhcp-options.xml.i>            #include <include/interface/dhcpv6-options.xml.i>            #include <include/interface/disable-link-detect.xml.i> diff --git a/interface-definitions/interfaces-bridge.xml.in b/interface-definitions/interfaces-bridge.xml.in index d52e213b6..1636411ec 100644 --- a/interface-definitions/interfaces-bridge.xml.in +++ b/interface-definitions/interfaces-bridge.xml.in @@ -34,7 +34,7 @@              </properties>              <defaultValue>300</defaultValue>            </leafNode> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/dhcp-options.xml.i>            #include <include/interface/dhcpv6-options.xml.i>            #include <include/interface/disable-link-detect.xml.i> diff --git a/interface-definitions/interfaces-dummy.xml.in b/interface-definitions/interfaces-dummy.xml.in index 201e9b179..00784fcdf 100644 --- a/interface-definitions/interfaces-dummy.xml.in +++ b/interface-definitions/interfaces-dummy.xml.in @@ -17,7 +17,7 @@          </properties>          <children>            #include <include/interface/address-ipv4-ipv6.xml.i> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/disable.xml.i>            <node name="ip">              <properties> diff --git a/interface-definitions/interfaces-ethernet.xml.in b/interface-definitions/interfaces-ethernet.xml.in index e9ae0acfe..e7c196c5c 100644 --- a/interface-definitions/interfaces-ethernet.xml.in +++ b/interface-definitions/interfaces-ethernet.xml.in @@ -20,7 +20,7 @@          </properties>          <children>            #include <include/interface/address-ipv4-ipv6-dhcp.xml.i> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/dhcp-options.xml.i>            #include <include/interface/dhcpv6-options.xml.i>            <leafNode name="disable-flow-control"> diff --git a/interface-definitions/interfaces-geneve.xml.in b/interface-definitions/interfaces-geneve.xml.in index f8e9909f8..ac9794870 100644 --- a/interface-definitions/interfaces-geneve.xml.in +++ b/interface-definitions/interfaces-geneve.xml.in @@ -17,7 +17,7 @@          </properties>          <children>            #include <include/interface/address-ipv4-ipv6.xml.i> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/disable.xml.i>            #include <include/interface/ipv4-options.xml.i>            #include <include/interface/ipv6-options.xml.i> diff --git a/interface-definitions/interfaces-input.xml.in b/interface-definitions/interfaces-input.xml.in index 97502d954..d90cf936f 100644 --- a/interface-definitions/interfaces-input.xml.in +++ b/interface-definitions/interfaces-input.xml.in @@ -17,7 +17,7 @@            </valueHelp>          </properties>          <children> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/disable.xml.i>            #include <include/interface/redirect.xml.i>          </children> diff --git a/interface-definitions/interfaces-l2tpv3.xml.in b/interface-definitions/interfaces-l2tpv3.xml.in index 0ebc3253d..1f0dd3d19 100644 --- a/interface-definitions/interfaces-l2tpv3.xml.in +++ b/interface-definitions/interfaces-l2tpv3.xml.in @@ -17,7 +17,7 @@          </properties>          <children>            #include <include/interface/address-ipv4-ipv6.xml.i> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            <leafNode name="destination-port">              <properties>                <help>UDP destination port for L2TPv3 tunnel</help> diff --git a/interface-definitions/interfaces-loopback.xml.in b/interface-definitions/interfaces-loopback.xml.in index 7f59db543..fe0944467 100644 --- a/interface-definitions/interfaces-loopback.xml.in +++ b/interface-definitions/interfaces-loopback.xml.in @@ -17,7 +17,7 @@          </properties>          <children>            #include <include/interface/address-ipv4-ipv6.xml.i> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            <node name="ip">              <properties>                <help>IPv4 routing parameters</help> diff --git a/interface-definitions/interfaces-macsec.xml.in b/interface-definitions/interfaces-macsec.xml.in index 441236ec2..4b4f9149d 100644 --- a/interface-definitions/interfaces-macsec.xml.in +++ b/interface-definitions/interfaces-macsec.xml.in @@ -115,7 +115,7 @@                </leafNode>              </children>            </node> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/disable.xml.i>            #include <include/interface/mtu-68-16000.xml.i>            <leafNode name="mtu"> diff --git a/interface-definitions/interfaces-openvpn.xml.in b/interface-definitions/interfaces-openvpn.xml.in index 7cfb9ee7a..63272a25f 100644 --- a/interface-definitions/interfaces-openvpn.xml.in +++ b/interface-definitions/interfaces-openvpn.xml.in @@ -33,7 +33,7 @@                </leafNode>              </children>            </node> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            <leafNode name="device-type">              <properties>                <help>OpenVPN interface device-type</help> diff --git a/interface-definitions/interfaces-pppoe.xml.in b/interface-definitions/interfaces-pppoe.xml.in index 35c4889ea..490f41471 100644 --- a/interface-definitions/interfaces-pppoe.xml.in +++ b/interface-definitions/interfaces-pppoe.xml.in @@ -22,7 +22,7 @@            #include <include/interface/no-default-route.xml.i>            #include <include/interface/default-route-distance.xml.i>            #include <include/interface/dhcpv6-options.xml.i> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/disable.xml.i>            <leafNode name="idle-timeout">              <properties> diff --git a/interface-definitions/interfaces-pseudo-ethernet.xml.in b/interface-definitions/interfaces-pseudo-ethernet.xml.in index 2fe07ffd5..5c73825c3 100644 --- a/interface-definitions/interfaces-pseudo-ethernet.xml.in +++ b/interface-definitions/interfaces-pseudo-ethernet.xml.in @@ -17,7 +17,7 @@          </properties>          <children>            #include <include/interface/address-ipv4-ipv6-dhcp.xml.i> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/dhcp-options.xml.i>            #include <include/interface/dhcpv6-options.xml.i>            #include <include/interface/disable-link-detect.xml.i> diff --git a/interface-definitions/interfaces-sstpc.xml.in b/interface-definitions/interfaces-sstpc.xml.in index 30b55a9fa..b569e9bde 100644 --- a/interface-definitions/interfaces-sstpc.xml.in +++ b/interface-definitions/interfaces-sstpc.xml.in @@ -16,7 +16,7 @@            </valueHelp>          </properties>          <children> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/disable.xml.i>            #include <include/interface/authentication.xml.i>            #include <include/interface/no-default-route.xml.i> diff --git a/interface-definitions/interfaces-tunnel.xml.in b/interface-definitions/interfaces-tunnel.xml.in index 333a5b178..17fe1e285 100644 --- a/interface-definitions/interfaces-tunnel.xml.in +++ b/interface-definitions/interfaces-tunnel.xml.in @@ -16,7 +16,7 @@            </valueHelp>          </properties>          <children> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/address-ipv4-ipv6.xml.i>            #include <include/interface/disable.xml.i>            #include <include/interface/disable-link-detect.xml.i> diff --git a/interface-definitions/interfaces-virtual-ethernet.xml.in b/interface-definitions/interfaces-virtual-ethernet.xml.in index 8059ec33b..864f658da 100644 --- a/interface-definitions/interfaces-virtual-ethernet.xml.in +++ b/interface-definitions/interfaces-virtual-ethernet.xml.in @@ -17,7 +17,7 @@          </properties>          <children>            #include <include/interface/address-ipv4-ipv6-dhcp.xml.i> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/dhcp-options.xml.i>            #include <include/interface/dhcpv6-options.xml.i>            #include <include/interface/disable.xml.i> diff --git a/interface-definitions/interfaces-vti.xml.in b/interface-definitions/interfaces-vti.xml.in index 11f001dc0..b116f7386 100644 --- a/interface-definitions/interfaces-vti.xml.in +++ b/interface-definitions/interfaces-vti.xml.in @@ -17,7 +17,7 @@          </properties>          <children>            #include <include/interface/address-ipv4-ipv6.xml.i> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/disable.xml.i>            #include <include/interface/ipv4-options.xml.i>            #include <include/interface/ipv6-options.xml.i> diff --git a/interface-definitions/interfaces-vxlan.xml.in b/interface-definitions/interfaces-vxlan.xml.in index 331f930d3..fb60c93d0 100644 --- a/interface-definitions/interfaces-vxlan.xml.in +++ b/interface-definitions/interfaces-vxlan.xml.in @@ -17,7 +17,7 @@          </properties>          <children>            #include <include/interface/address-ipv4-ipv6.xml.i> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/disable.xml.i>            <leafNode name="external">              <properties> diff --git a/interface-definitions/interfaces-wireguard.xml.in b/interface-definitions/interfaces-wireguard.xml.in index 35e223588..6342b21cf 100644 --- a/interface-definitions/interfaces-wireguard.xml.in +++ b/interface-definitions/interfaces-wireguard.xml.in @@ -17,7 +17,7 @@          </properties>          <children>            #include <include/interface/address-ipv4-ipv6.xml.i> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/disable.xml.i>            #include <include/port-number.xml.i>            #include <include/interface/mtu-68-16000.xml.i> diff --git a/interface-definitions/interfaces-wireless.xml.in b/interface-definitions/interfaces-wireless.xml.in index 5271df624..aff5071b2 100644 --- a/interface-definitions/interfaces-wireless.xml.in +++ b/interface-definitions/interfaces-wireless.xml.in @@ -467,7 +467,7 @@                <constraintErrorMessage>Invalid ISO/IEC 3166-1 Country Code</constraintErrorMessage>              </properties>            </leafNode> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/dhcp-options.xml.i>            #include <include/interface/dhcpv6-options.xml.i>            <leafNode name="disable-broadcast-ssid"> diff --git a/interface-definitions/interfaces-wwan.xml.in b/interface-definitions/interfaces-wwan.xml.in index 758784540..5fa3be8db 100644 --- a/interface-definitions/interfaces-wwan.xml.in +++ b/interface-definitions/interfaces-wwan.xml.in @@ -28,7 +28,7 @@            #include <include/interface/dhcp-options.xml.i>            #include <include/interface/dhcpv6-options.xml.i>            #include <include/interface/authentication.xml.i> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/disable.xml.i>            #include <include/interface/disable-link-detect.xml.i>            #include <include/interface/mirror.xml.i> diff --git a/interface-definitions/netns.xml.in b/interface-definitions/netns.xml.in index 088985cb6..87880e96a 100644 --- a/interface-definitions/netns.xml.in +++ b/interface-definitions/netns.xml.in @@ -15,7 +15,7 @@            <constraintErrorMessage>Netns name must be alphanumeric and can contain hyphens and underscores.</constraintErrorMessage>          </properties>          <children> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>          </children>        </tagNode>      </children> diff --git a/interface-definitions/service-console-server.xml.in b/interface-definitions/service-console-server.xml.in index fb71538dd..fc6dbe954 100644 --- a/interface-definitions/service-console-server.xml.in +++ b/interface-definitions/service-console-server.xml.in @@ -27,7 +27,7 @@                </constraint>              </properties>              <children> -              #include <include/interface/description.xml.i> +              #include <include/generic-description.xml.i>                <leafNode name="alias">                  <properties>                    <help>Human-readable name for this console</help> diff --git a/interface-definitions/vrf.xml.in b/interface-definitions/vrf.xml.in index 3604b41c8..96c6d8be2 100644 --- a/interface-definitions/vrf.xml.in +++ b/interface-definitions/vrf.xml.in @@ -26,7 +26,7 @@            </valueHelp>          </properties>          <children> -          #include <include/interface/description.xml.i> +          #include <include/generic-description.xml.i>            #include <include/interface/disable.xml.i>            <node name="ip">              <properties>  | 
